From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dupWW-0000DF-7W for qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dupWT-0005DH-4h for qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:39:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dupWS-0005CV-Ru for qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:39:21 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8L0dI1o095185 for ; Wed, 20 Sep 2017 20:39:19 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0a-001b2d01.pphosted.com with ESMTP id 2d3v9fdk43-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 20 Sep 2017 20:39:18 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Sep 2017 20:39:13 -0400 Date: Thu, 21 Sep 2017 08:39:09 +0800 From: Dong Jia Shi References: <20170919182745.90280-1-pasic@linux.vnet.ibm.com> <20170919182745.90280-5-pasic@linux.vnet.ibm.com> <20170920074751.GI11080@bjsdjshi@linux.vnet.ibm.com> <20170920102537.6b329909.cohuck@redhat.com> <1254ddda-74a6-fa8e-5d7c-9ab995497a04@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254ddda-74a6-fa8e-5d7c-9ab995497a04@linux.vnet.ibm.com> Message-Id: <20170921003909.GK11080@bjsdjshi@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Cornelia Huck , Dong Jia Shi , Pierre Morel , qemu-devel@nongnu.org * Halil Pasic [2017-09-20 13:02:59 +0200]: > > > On 09/20/2017 10:25 AM, Cornelia Huck wrote: > > On Wed, 20 Sep 2017 15:47:51 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-09-19 20:27:44 +0200]: > > > >>> @@ -828,7 +836,9 @@ void ccw_dstream_init(CcwDataStream *cds, CCW1 const *ccw, ORB const *orb) > >>> g_assert(!(orb->ctrl1 & ORB_CTRL1_MASK_MIDAW)); > >>> cds->flags = (orb->ctrl0 & ORB_CTRL0_MASK_I2K ? CDS_F_I2K : 0) | > >>> (orb->ctrl0 & ORB_CTRL0_MASK_C64 ? CDS_F_C64 : 0) | > >>> + (orb->ctrl0 & ORB_CTRL0_MASK_FMT ? CDS_F_FMT : 0) | > >> This reminds me one more question: > >> Calling ccw_dsteram_init() after copy_ccw_from_guest() may lead to a > >> fmt-1 @ccw with an @orb that designates fmt-0 ccw. This sounds insane. > > > > That's just a consequence of us translating everything to format-1 > > ccws. A bit confusing, but no problem if we pay attention to the format > > bit everywhere it makes a difference. > > > > Agree. Ok. I'm fine with this. > > Halil -- Dong Jia Shi