From: "Daniel P. Berrange" <berrange@redhat.com>
To: Brandon Carpenter <brandon.carpenter@cypherpath.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC
Date: Thu, 21 Sep 2017 10:55:28 +0100 [thread overview]
Message-ID: <20170921095528.GE26740@redhat.com> (raw)
In-Reply-To: <1505926567.32618.0@smtp.gmail.com>
On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:
> How are things looking, Daniel. I believe every comment from the previous
> version of the series was addressed.
>
> I also wanted to mention that I put together a Python script, which acts as
> a proxy between noVNC and qemu, and can inject various frame types, fragment
> frames, and shutdown the socket in various ways to help exercise the
> different code paths. I would be happy to post it here to help test the
> changes.
Sorry for the delay - I've reviewed this now and it looks good. I've made a
few whitespace changes in places, but I've queued it for my next pull request
now.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-09-21 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:21 [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 1/7] io: Always remove an old channel watch before adding a new one Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 2/7] io: Small updates in preparation for websocket changes Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 3/7] io: Add support for fragmented websocket binary frames Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 4/7] io: Allow empty websocket payload Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 5/7] io: Ignore websocket PING and PONG frames Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 6/7] io: Reply to ping frames Brandon Carpenter
2017-09-12 15:21 ` [Qemu-devel] [PATCH v3 7/7] io: Attempt to send websocket close messages to client Brandon Carpenter
2017-09-18 14:48 ` [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully support the RFC Stefan Hajnoczi
2017-09-20 16:56 ` Brandon Carpenter
2017-09-21 9:55 ` Daniel P. Berrange [this message]
2017-09-21 15:54 ` Brandon Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921095528.GE26740@redhat.com \
--to=berrange@redhat.com \
--cc=brandon.carpenter@cypherpath.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.