From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf Date: Thu, 21 Sep 2017 14:22:11 +0300 Message-ID: <20170921112211.GG4914@intel.com> References: <1505892308-6843-1-git-send-email-arvind.yadav.cs@gmail.com> <1505892308-6843-2-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 247A86E839 for ; Thu, 21 Sep 2017 11:22:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1505892308-6843-2-git-send-email-arvind.yadav.cs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arvind Yadav Cc: linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMjAsIDIwMTcgYXQgMTI6NTU6MDdQTSArMDUzMCwgQXJ2aW5kIFlhZGF2IHdy b3RlOgo+IGthc3ByaW50ZigpIGNhbiBmYWlsIGhlcmUgYW5kIHdlIG11c3QgY2hlY2sgaXRzIHJl dHVybiB2YWx1ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcnZpbmQgWWFkYXYgPGFydmluZC55YWRh di5jc0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS90ZWdyYS9kYy5jIHwgMiAr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS90ZWdyYS9kYy5jIGIvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RjLmMKPiBp bmRleCA0ZGYzOTExLi5mMzIxNGExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS90ZWdy YS9kYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RjLmMKPiBAQCAtMTY5NSw2ICsx Njk1LDggQEAgc3RhdGljIGludCB0ZWdyYV9kY19kZWJ1Z2ZzX2luaXQoc3RydWN0IHRlZ3JhX2Rj ICpkYywgc3RydWN0IGRybV9taW5vciAqbWlub3IpCj4gIAlpbnQgZXJyOwo+ICAKPiAgCW5hbWUg PSBrYXNwcmludGYoR0ZQX0tFUk5FTCwgImRjLiVkIiwgZGMtPnBpcGUpOwo+ICsJaWYgKCFuYW1l KQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICAJZGMtPmRlYnVnZnMgPSBkZWJ1Z2ZzX2NyZWF0ZV9k aXIobmFtZSwgbWlub3ItPmRlYnVnZnNfcm9vdCk7CgpJbmRlZWQsIGRvZXNuJ3QgbG9vayBsaWtl IGRlYnVnZnNfY3JlYXRlX2RpcigpIGNhbiBiZSBzYWZlbHkgY2FsbGVkIHcvCm5hbWU9PU5VTEwu CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KCj4gIAlrZnJlZShuYW1lKTsKPiAgCj4gLS0gCj4gMS45LjEKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbdIULWR (ORCPT ); Thu, 21 Sep 2017 07:22:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:2763 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdIULWQ (ORCPT ); Thu, 21 Sep 2017 07:22:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,425,1500966000"; d="scan'208";a="137870028" Date: Thu, 21 Sep 2017 14:22:11 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Arvind Yadav Cc: thierry.reding@gmail.com, airlied@linux.ie, jonathanh@nvidia.com, daniel.vetter@intel.com, jani.nikula@linux.intel.com, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf Message-ID: <20170921112211.GG4914@intel.com> References: <1505892308-6843-1-git-send-email-arvind.yadav.cs@gmail.com> <1505892308-6843-2-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1505892308-6843-2-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2017 at 12:55:07PM +0530, Arvind Yadav wrote: > kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/tegra/dc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 4df3911..f3214a1 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -1695,6 +1695,8 @@ static int tegra_dc_debugfs_init(struct tegra_dc *dc, struct drm_minor *minor) > int err; > > name = kasprintf(GFP_KERNEL, "dc.%d", dc->pipe); > + if (!name) > + return -ENOMEM; > dc->debugfs = debugfs_create_dir(name, minor->debugfs_root); Indeed, doesn't look like debugfs_create_dir() can be safely called w/ name==NULL. Reviewed-by: Ville Syrjälä > kfree(name); > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC