From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm: Release memory obtained by kasprintf Date: Thu, 21 Sep 2017 14:24:43 +0300 Message-ID: <20170921112443.GH4914@intel.com> References: <1505892308-6843-1-git-send-email-arvind.yadav.cs@gmail.com> <1505892308-6843-3-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07D566E845 for ; Thu, 21 Sep 2017 11:24:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1505892308-6843-3-git-send-email-arvind.yadav.cs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arvind Yadav Cc: linux-kernel@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMjAsIDIwMTcgYXQgMTI6NTU6MDhQTSArMDUzMCwgQXJ2aW5kIFlhZGF2IHdy b3RlOgo+IEZyZWUgbWVtb3J5IHJlZ2lvbiwgaWYgZHJtX2NydGNfaW5pdF93aXRoX3BsYW5lcyBp cyBub3Qgc3VjY2Vzc2Z1bC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcnZpbmQgWWFkYXYgPGFydmlu ZC55YWRhdi5jc0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5j IHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5j Cj4gaW5kZXggNWFmMjVjZS4uY2Q0ZTYyOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gQEAgLTMyOCw2 ICszMjgsNyBAQCBpbnQgZHJtX2NydGNfaW5pdF93aXRoX3BsYW5lcyhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAlyZXQgPSBkcm1fY3J0Y19jcmNfaW5p dChjcnRjKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlkcm1fbW9kZV9vYmplY3RfdW5yZWdpc3Rlcihk ZXYsICZjcnRjLT5iYXNlKTsKPiArCQlrZnJlZShjcnRjLT5uYW1lKTsKCkxvb2tzIGNvcnJlY3Qu IEhvd2V2ZXIgbXkgb2NkIHdvdWxkIHdpc2ggdGhlIGtmcmVlKCkgdG8gcHJlY2VkZQpkcm1fbW9k ZV9vYmplY3RfdW5yZWdpc3RlcigpIHRvIG1ha2UgdGhlIHVud2luZGluZyBtaXJyb3IgdGhlCmFs bG9jYXRpb24vcmVnaXN0cmF0aW9uIHNlcXVlbmNlLgoKPiAgCQlyZXR1cm4gcmV0Owo+ICAJfQo+ ICAKPiAtLSAKPiAxLjkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbdIULYv (ORCPT ); Thu, 21 Sep 2017 07:24:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:7794 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdIULYs (ORCPT ); Thu, 21 Sep 2017 07:24:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,425,1500966000"; d="scan'208";a="1197544724" Date: Thu, 21 Sep 2017 14:24:43 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Arvind Yadav Cc: thierry.reding@gmail.com, airlied@linux.ie, jonathanh@nvidia.com, daniel.vetter@intel.com, jani.nikula@linux.intel.com, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm: Release memory obtained by kasprintf Message-ID: <20170921112443.GH4914@intel.com> References: <1505892308-6843-1-git-send-email-arvind.yadav.cs@gmail.com> <1505892308-6843-3-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1505892308-6843-3-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2017 at 12:55:08PM +0530, Arvind Yadav wrote: > Free memory region, if drm_crtc_init_with_planes is not successful. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/drm_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 5af25ce..cd4e628 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -328,6 +328,7 @@ int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc, > ret = drm_crtc_crc_init(crtc); > if (ret) { > drm_mode_object_unregister(dev, &crtc->base); > + kfree(crtc->name); Looks correct. However my ocd would wish the kfree() to precede drm_mode_object_unregister() to make the unwinding mirror the allocation/registration sequence. > return ret; > } > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC