Re: [meta-processor-sdk][PATCH] mstpd: add support for Multiple Spanning Tree Protocol Daemon

[Denys Dmytriyenko <denys@ti.com>]

Please submit this to meta-arago layer.


On Thu, Sep 21, 2017 at 02:57:45PM -0400, Jacob Stiffler wrote:
> From: Michael Erdahl <m-erdahl@ti.com>
> 
> Project repo: https://github.com/mstpd/mstpd
> 
> Signed-off-by: Michael Erdahl <m-erdahl@ti.com>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> Michael,
> 
> Here is my refactoring of your patches for meta-processor-sdk. Let me know if you see any problems.
> 
> 
>  .../packagegroups/packagegroup-arago-test.bbappend |  5 +++
>  recipes-support/mstpctl/mstpd_git.bb               | 39 ++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 recipes-core/packagegroups/packagegroup-arago-test.bbappend
>  create mode 100644 recipes-support/mstpctl/mstpd_git.bb
> 
> diff --git a/recipes-core/packagegroups/packagegroup-arago-test.bbappend b/recipes-core/packagegroups/packagegroup-arago-test.bbappend
> new file mode 100644
> index 0000000..4cb58db
> --- /dev/null
> +++ b/recipes-core/packagegroups/packagegroup-arago-test.bbappend
> @@ -0,0 +1,5 @@
> +PR_append = ".tisdk0"
> +
> +ARAGO_TEST_append_ti33x = " mstpd"
> +ARAGO_TEST_append_ti43x = " mstpd"
> +ARAGO_TEST_append_omap-a15 = " mstpd"
> diff --git a/recipes-support/mstpctl/mstpd_git.bb b/recipes-support/mstpctl/mstpd_git.bb
> new file mode 100644
> index 0000000..abe2ca9
> --- /dev/null
> +++ b/recipes-support/mstpctl/mstpd_git.bb
> @@ -0,0 +1,39 @@
> +# Recipe created by recipetool
> +# This is the basis of a recipe and may need further editing in order to be fully functional.
> +# (Feel free to remove these comments when editing.)

Please remove stub comments.


> +SUMMARY = "Multiple Spanning Tree Protocol Daemon"
> +
> +# WARNING: the following LICENSE and LIC_FILES_CHKSUM values are best guesses - it is
> +# your responsibility to verify that the values are complete and correct.
> +#
> +# NOTE: multiple licenses have been detected; if that is correct you should separate
> +# these in the LICENSE value using & if the multiple licenses all apply, or | if there
> +# is a choice between the multiple licenses. If in doubt, check the accompanying
> +# documentation to determine which situation is applicable.
> +#
> +# The following license files were not able to be identified and are
> +# represented as "Unknown" below, you will need to check them yourself:
> +#   debian/copyright
> +#

Same here - please remove stub comments.


> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=4325afd396febcb659c36b49533135d4 \
> +                    file://debian/copyright;md5=332234a99007d25da40f41ee96aa388f"
> +
> +SRC_URI = "git://github.com/mstpd/mstpd.git;protocol=https"

You might not want to use https by default...


> +# Modify these as desired

^^^


> +PV = "0.0.5+git${SRCPV}"
> +SRCREV = "3dbd68c11dfed6c8f6f2423f429d3b4a2acc27f8"
> +
> +S = "${WORKDIR}/git"
> +
> +DEPENDS = "python"
> +RDEPENDS_${PN} = "python-core"
> +
> +# NOTE: if this software is not capable of being built in a separate build directory
> +# from the source, you should replace autotools with autotools-brokensep in the
> +# inherit line

^^^ Here as well.


> +inherit autotools
> +
> +# Specify any options you want to pass to the configure script using EXTRA_OECONF:

^^^

> +EXTRA_OECONF = "--sbindir=/sbin"
> -- 
> 2.7.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago