From: Eric Biggers <ebiggers3@gmail.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()
Date: Thu, 21 Sep 2017 20:37:43 +0000 [thread overview]
Message-ID: <20170921203743.GA89627@gmail.com> (raw)
In-Reply-To: <28352.1505835968@warthog.procyon.org.uk>
On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link()
> > were to fail, we would leak a reference to the 'struct cred'. Currently
> > this can only happen if alloc_key() fails to to allocate memory. But it
> > still should be fixed, as it is a more severe bug waiting to happen.
>
> It might be better to combine request_key_auth_destroy() and the error path
> that you're altering in request_key_auth_new() by pulling it into a separate
> function.
>
> David
Agreed, I'll do that.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiggers3@gmail.com (Eric Biggers)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()
Date: Thu, 21 Sep 2017 13:37:43 -0700 [thread overview]
Message-ID: <20170921203743.GA89627@gmail.com> (raw)
In-Reply-To: <28352.1505835968@warthog.procyon.org.uk>
On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link()
> > were to fail, we would leak a reference to the 'struct cred'. Currently
> > this can only happen if alloc_key() fails to to allocate memory. But it
> > still should be fixed, as it is a more severe bug waiting to happen.
>
> It might be better to combine request_key_auth_destroy() and the error path
> that you're altering in request_key_auth_new() by pulling it into a separate
> function.
>
> David
Agreed, I'll do that.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, Michael Halcrow <mhalcrow@google.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] KEYS: fix cred refcount leak in request_key_auth_new()
Date: Thu, 21 Sep 2017 13:37:43 -0700 [thread overview]
Message-ID: <20170921203743.GA89627@gmail.com> (raw)
In-Reply-To: <28352.1505835968@warthog.procyon.org.uk>
On Tue, Sep 19, 2017 at 04:46:08PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > In request_key_auth_new(), if alloc_key() or key_instantiate_and_link()
> > were to fail, we would leak a reference to the 'struct cred'. Currently
> > this can only happen if alloc_key() fails to to allocate memory. But it
> > still should be fixed, as it is a more severe bug waiting to happen.
>
> It might be better to combine request_key_auth_destroy() and the error path
> that you're altering in request_key_auth_new() by pulling it into a separate
> function.
>
> David
Agreed, I'll do that.
Eric
next prev parent reply other threads:[~2017-09-21 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:33 [PATCH] KEYS: fix cred refcount leak in request_key_auth_new() Eric Biggers
2017-09-18 18:33 ` Eric Biggers
2017-09-18 18:33 ` Eric Biggers
2017-09-19 15:46 ` David Howells
2017-09-19 15:46 ` David Howells
2017-09-19 15:46 ` David Howells
2017-09-21 20:37 ` Eric Biggers [this message]
2017-09-21 20:37 ` Eric Biggers
2017-09-21 20:37 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921203743.GA89627@gmail.com \
--to=ebiggers3@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.