From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6468338986973659136 X-Received: by 10.31.107.141 with SMTP id k13mr5180622vki.79.1506030432649; Thu, 21 Sep 2017 14:47:12 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.55.10.147 with SMTP id 141ls1120344qkk.12.gmail; Thu, 21 Sep 2017 14:47:12 -0700 (PDT) X-Received: by 10.55.17.10 with SMTP id b10mr5053669qkh.54.1506030432014; Thu, 21 Sep 2017 14:47:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506030431; cv=none; d=google.com; s=arc-20160816; b=f5DXacQxPOLOWca3kOwGB7o6MmttNlwQQws790UUQQ9GeVkNQx2lgAu5wsv1smQHHL W6r/B63bMKxhOCE39MeYId+zBxVRTw/h1F7UzDRXt8cQ1PM5H/xgl+q1zahE2H7VQ1TB DxplCOfHwantXgADyjqVAoNgvcCuM/FKd7w5nZD7BkktuclXI71I/ofwrKq3BLOXxgRw B8OcRZ/GcQUPPOqdW+TXtwmjcwu6W/0zIeOf3EQrvg3aD+OfkX7N7mOqUHVK3LDr782u D8OBlpPFZg70Eu4zsMbNRRXNTB6pT7tLO8UMGNNSkDnLBz5RZIRcr0zkW4BaJCKHZ6MR cgig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=/Ct3hCMVFTBL3XkCJGszz4Zi06v6EWhNy2KOlg3EXNA=; b=hl5M2qU7tv/UKqxQDl4CJKZbMk6mDKUecJpnzI9V2x8OtwYFq1FBccqEv+OHw1dlKZ wyrRAGzJuim+EMcAFiXsEiW9j8yu6x0Ld7Ej7g+pieIB4beNcgt9yLRD6RPU3ipiXBHN PJCrWcDxdve12qZQSPzYaD2X35tDmv7UAQiczqtCrNrhw/o9Lsi7S4EwwVJm9I1FlT8L SDGL9SX6FxfTzZsHpZ8FAqU0pFaFYIFtgjwWb87Bi153DvHw5AXVXbuj8SljXd53Bv4f TPXMxPwFmpL8KikuXwy1VGbS1Em0Mzm8CbuJ9RrBXmy2SPZ/EM8B8F3NAJRqHVLLzCZf UvEQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KrlIUx4V; spf=pass (google.com: domain of hamohammed.sa@gmail.com designates 2607:f8b0:400e:c05::242 as permitted sender) smtp.mailfrom=hamohammed.sa@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com. [2607:f8b0:400e:c05::242]) by gmr-mx.google.com with ESMTPS id k76si252886pfb.5.2017.09.21.14.47.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 14:47:11 -0700 (PDT) Received-SPF: pass (google.com: domain of hamohammed.sa@gmail.com designates 2607:f8b0:400e:c05::242 as permitted sender) client-ip=2607:f8b0:400e:c05::242; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KrlIUx4V; spf=pass (google.com: domain of hamohammed.sa@gmail.com designates 2607:f8b0:400e:c05::242 as permitted sender) smtp.mailfrom=hamohammed.sa@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-pg0-x242.google.com with SMTP id v5so4092413pgn.4 for ; Thu, 21 Sep 2017 14:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/Ct3hCMVFTBL3XkCJGszz4Zi06v6EWhNy2KOlg3EXNA=; b=KrlIUx4VYW8EaUh77Pc/Q8ylanCViAgovtWXgZTT3goarXRwOIxL4Hi8sCJvpENj53 Ae/l3+N8arkbzF2OjHf5tyQRyAt+fTbHXdmDJYBaQLhjL1SDL/JYA67aLRyxeziN3iBE eUiOojTaijn0MkiHOhUxBPlWnzo8+psotMa7U2wbddOhBT/ElzqUQ5N5KEDxov0XJvRV AK6iw+W5xpaPD1darEToP41+MPXQQTkVwLzVGp0mbP4rT1Sdp5uiyP9GV7ycmQBT977F /DQKSaCx4AeUXMQxFOyockcJJ8wWw7iAk18WPIy0Ei3aom9PEGJcynhExHOPzvTcgrML s+gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/Ct3hCMVFTBL3XkCJGszz4Zi06v6EWhNy2KOlg3EXNA=; b=CM8X1dr1ZHAeUEtmrYqEqm1bLsn4yFE7tdUCAXg832GzHSPUubVKhbCmgTwXqXpV8C nAvozlnUbiYMzj9pybJDDESeuRdbgpYnVzBXRagysMSXH+6B0acO18rH0teydEntPUI7 +89VbGJkU2mqS+Oj2P7fhiW3qnVpK12wEAFzcgjZRAolfCJvvWV3OKAfPg+0GwHtPtgj ffg+l/5pReKojceNGF2lqbwd4VE26soMFau6kGs7FuQM4SMP/jwZlOxAT2ONKZG2I/N2 wT/jydD82LiFwZ9u5n/dGdJV95hREaG91Fs9+Cq99qVnAtzNwXUnBxlfaOGCTEq/FKNt hQUg== X-Gm-Message-State: AHPjjUhD/f6+aTPm2qoVZMF2GQGVchSEE4YvlscSBRyI+1Ywu4YP7h/6 XSty68vLbgNnnU8NyCgONrw= X-Google-Smtp-Source: AOwi7QCE9MxkdCkFjDHz2udswaWxDW+2Pn6RWHEEglW2q1WS1vQnJb8PW4Yet8qm7+sSPnGy7EBSLg== X-Received: by 10.98.26.201 with SMTP id a192mr6936339pfa.311.1506030431746; Thu, 21 Sep 2017 14:47:11 -0700 (PDT) Return-Path: Received: from Haneen ([64.77.242.50]) by smtp.gmail.com with ESMTPSA id 28sm3850518pfl.14.2017.09.21.14.47.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 14:47:10 -0700 (PDT) Date: Thu, 21 Sep 2017 15:47:07 -0600 From: Haneen Mohammed To: Julia Lawall Cc: outreachy-kernel , dri-devel@lists.freedesktop.org, Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , gregkh@linuxfoundation.org Subject: Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment Message-ID: <20170921214707.GA22325@Haneen> References: <20170921210424.GA21951@Haneen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) On Thu, Sep 21, 2017 at 11:16:44PM +0200, Julia Lawall wrote: > > > On Thu, 21 Sep 2017, Haneen Mohammed wrote: > > > Remove obsolete comment which was initially added in 2008 to annotate > > that idr_find() was used before idr_remove() since idr_remove() didn't > > use to return feedback. The comment now is irrelevant with > > commit f6cd7daecff5 ("drm: Release driver references to handle before > > making it available again"). > > Why did you send it again? > > julia > I forgot to include the dri-devel mailing list for the first patch. Haneen > > > > Signed-off-by: Haneen Mohammed > > --- > > drivers/gpu/drm/drm_gem.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > > index c55f338..b9bddaa 100644 > > --- a/drivers/gpu/drm/drm_gem.c > > +++ b/drivers/gpu/drm/drm_gem.c > > @@ -282,15 +282,6 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle) > > { > > struct drm_gem_object *obj; > > > > - /* This is gross. The idr system doesn't let us try a delete and > > - * return an error code. It just spews if you fail at deleting. > > - * So, we have to grab a lock around finding the object and then > > - * doing the delete on it and dropping the refcount, or the user > > - * could race us to double-decrement the refcount and cause a > > - * use-after-free later. Given the frequency of our handle lookups, > > - * we may want to use ida for number allocation and a hash table > > - * for the pointers, anyway. > > - */ > > spin_lock(&filp->table_lock); > > > > /* Check if we currently have a reference on the object */ > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170921210424.GA21951%40Haneen. > > For more options, visit https://groups.google.com/d/optout. > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haneen Mohammed Subject: Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment Date: Thu, 21 Sep 2017 15:47:07 -0600 Message-ID: <20170921214707.GA22325@Haneen> References: <20170921210424.GA21951@Haneen> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ABD16E926 for ; Thu, 21 Sep 2017 21:47:12 +0000 (UTC) Received: by mail-pg0-x244.google.com with SMTP id j16so4100290pga.2 for ; Thu, 21 Sep 2017 14:47:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: gregkh@linuxfoundation.org, outreachy-kernel , dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMjEsIDIwMTcgYXQgMTE6MTY6NDRQTSArMDIwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IAo+IAo+IE9uIFRodSwgMjEgU2VwIDIwMTcsIEhhbmVlbiBNb2hhbW1lZCB3cm90ZToK PiAKPiA+IFJlbW92ZSBvYnNvbGV0ZSBjb21tZW50IHdoaWNoIHdhcyBpbml0aWFsbHkgYWRkZWQg aW4gMjAwOCB0byBhbm5vdGF0ZQo+ID4gdGhhdCBpZHJfZmluZCgpIHdhcyB1c2VkIGJlZm9yZSBp ZHJfcmVtb3ZlKCkgc2luY2UgaWRyX3JlbW92ZSgpIGRpZG4ndAo+ID4gdXNlIHRvIHJldHVybiBm ZWVkYmFjay4gVGhlIGNvbW1lbnQgbm93IGlzIGlycmVsZXZhbnQgd2l0aAo+ID4gY29tbWl0IGY2 Y2Q3ZGFlY2ZmNSAoImRybTogUmVsZWFzZSBkcml2ZXIgcmVmZXJlbmNlcyB0byBoYW5kbGUgYmVm b3JlCj4gPiBtYWtpbmcgaXQgYXZhaWxhYmxlIGFnYWluIikuCj4gCj4gV2h5IGRpZCB5b3Ugc2Vu ZCBpdCBhZ2Fpbj8KPiAKPiBqdWxpYQo+IAoKSSBmb3Jnb3QgdG8gaW5jbHVkZSB0aGUgZHJpLWRl dmVsIG1haWxpbmcgbGlzdCBmb3IgdGhlIGZpcnN0IHBhdGNoLgoKSGFuZWVuCgo+ID4KPiA+IFNp Z25lZC1vZmYtYnk6IEhhbmVlbiBNb2hhbW1lZCA8aGFtb2hhbW1lZC5zYUBnbWFpbC5jb20+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jIHwgOSAtLS0tLS0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgOSBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+IGluZGV4 IGM1NWYzMzguLmI5YmRkYWEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dl bS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gPiBAQCAtMjgyLDE1ICsy ODIsNiBAQCBkcm1fZ2VtX2hhbmRsZV9kZWxldGUoc3RydWN0IGRybV9maWxlICpmaWxwLCB1MzIg aGFuZGxlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmo7Cj4gPgo+ID4g LQkvKiBUaGlzIGlzIGdyb3NzLiBUaGUgaWRyIHN5c3RlbSBkb2Vzbid0IGxldCB1cyB0cnkgYSBk ZWxldGUgYW5kCj4gPiAtCSAqIHJldHVybiBhbiBlcnJvciBjb2RlLiAgSXQganVzdCBzcGV3cyBp ZiB5b3UgZmFpbCBhdCBkZWxldGluZy4KPiA+IC0JICogU28sIHdlIGhhdmUgdG8gZ3JhYiBhIGxv Y2sgYXJvdW5kIGZpbmRpbmcgdGhlIG9iamVjdCBhbmQgdGhlbgo+ID4gLQkgKiBkb2luZyB0aGUg ZGVsZXRlIG9uIGl0IGFuZCBkcm9wcGluZyB0aGUgcmVmY291bnQsIG9yIHRoZSB1c2VyCj4gPiAt CSAqIGNvdWxkIHJhY2UgdXMgdG8gZG91YmxlLWRlY3JlbWVudCB0aGUgcmVmY291bnQgYW5kIGNh dXNlIGEKPiA+IC0JICogdXNlLWFmdGVyLWZyZWUgbGF0ZXIuICBHaXZlbiB0aGUgZnJlcXVlbmN5 IG9mIG91ciBoYW5kbGUgbG9va3VwcywKPiA+IC0JICogd2UgbWF5IHdhbnQgdG8gdXNlIGlkYSBm b3IgbnVtYmVyIGFsbG9jYXRpb24gYW5kIGEgaGFzaCB0YWJsZQo+ID4gLQkgKiBmb3IgdGhlIHBv aW50ZXJzLCBhbnl3YXkuCj4gPiAtCSAqLwo+ID4gIAlzcGluX2xvY2soJmZpbHAtPnRhYmxlX2xv Y2spOwo+ID4KPiA+ICAJLyogQ2hlY2sgaWYgd2UgY3VycmVudGx5IGhhdmUgYSByZWZlcmVuY2Ug b24gdGhlIG9iamVjdCAqLwo+ID4gLS0KPiA+IDIuNy40Cj4gPgo+ID4gLS0KPiA+IFlvdSByZWNl aXZlZCB0aGlzIG1lc3NhZ2UgYmVjYXVzZSB5b3UgYXJlIHN1YnNjcmliZWQgdG8gdGhlIEdvb2ds ZSBHcm91cHMgIm91dHJlYWNoeS1rZXJuZWwiIGdyb3VwLgo+ID4gVG8gdW5zdWJzY3JpYmUgZnJv bSB0aGlzIGdyb3VwIGFuZCBzdG9wIHJlY2VpdmluZyBlbWFpbHMgZnJvbSBpdCwgc2VuZCBhbiBl bWFpbCB0byBvdXRyZWFjaHkta2VybmVsK3Vuc3Vic2NyaWJlQGdvb2dsZWdyb3Vwcy5jb20uCj4g PiBUbyBwb3N0IHRvIHRoaXMgZ3JvdXAsIHNlbmQgZW1haWwgdG8gb3V0cmVhY2h5LWtlcm5lbEBn b29nbGVncm91cHMuY29tLgo+ID4gVG8gdmlldyB0aGlzIGRpc2N1c3Npb24gb24gdGhlIHdlYiB2 aXNpdCBodHRwczovL2dyb3Vwcy5nb29nbGUuY29tL2QvbXNnaWQvb3V0cmVhY2h5LWtlcm5lbC8y MDE3MDkyMTIxMDQyNC5HQTIxOTUxJTQwSGFuZWVuLgo+ID4gRm9yIG1vcmUgb3B0aW9ucywgdmlz aXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL29wdG91dC4KPiA+Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=