From: Adrian Salido <salidoa@google.com>
To: dri-devel@lists.freedesktop.org
Cc: Adrian Salido <salidoa@google.com>
Subject: [hwc PATCH v1] drm_hwcomposer: reorder source layers according to zorder
Date: Thu, 21 Sep 2017 16:53:48 -0700 [thread overview]
Message-ID: <20170921235348.165560-1-salidoa@google.com> (raw)
Precomp layers may be added to the back at different points which may
cause elements to be unsorted. Make sure that these are sorted after
provisioning planes to ensure right composition based on zorder.
Signed-off-by: Adrian Salido <salidoa@google.com>
---
drmdisplaycomposition.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drmdisplaycomposition.cpp b/drmdisplaycomposition.cpp
index 293160bfd012..0f8084b39706 100644
--- a/drmdisplaycomposition.cpp
+++ b/drmdisplaycomposition.cpp
@@ -379,6 +379,9 @@ int DrmDisplayComposition::Plan(SquashState *squash,
if (!i.plane())
continue;
+ // make sure that source layers are ordered based on zorder
+ std::sort(i.source_layers().begin(), i.source_layers().end());
+
std::vector<DrmPlane *> *container;
if (i.plane()->type() == DRM_PLANE_TYPE_PRIMARY)
container = primary_planes;
--
2.14.1.821.g8fa685d3b7-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-09-21 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 23:53 Adrian Salido [this message]
2017-09-22 0:02 ` [hwc PATCH v1] drm_hwcomposer: reorder source layers according to zorder Zach Reizner
2017-09-22 16:25 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921235348.165560-1-salidoa@google.com \
--to=salidoa@google.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.