From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvDvQ-0000nY-D6 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvDvN-0000hx-2I for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:42:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39220) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvDvM-0000gw-SN for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:42:40 -0400 Date: Fri, 22 Sep 2017 10:42:35 +0800 From: Fam Zheng Message-ID: <20170922024235.GC1397@lemon.lan> References: <20170921150755.19914-1-famz@redhat.com> <20170921150755.19914-4-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v11 03/13] scripts: Add archive-source.sh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, berrange@redhat.com, Alex =?iso-8859-1?Q?Benn=E9e?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Peter Maydell , stefanha@redhat.com, Cleber Rosa , pbonzini@redhat.com, Kamil Rytarowski On Thu, 09/21 10:22, Eric Blake wrote: > On 09/21/2017 10:07 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100755 scripts/archive-source.sh > > > > diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh > > new file mode 100755 > > index 0000000000..8aa363d3a0 > > --- /dev/null > > +++ b/scripts/archive-source.sh > > @@ -0,0 +1,51 @@ > > +#!/bin/bash > > +# > > +# Author: Fam Zheng > > +# > > +# Archive source tree, including submodules. This is created for test code to > > +# export the source files, in order to be built in a different enviornment, > > s/enviornment/environment/ > > > +# such as in a docker instance or VM. > > +# > > +# This code is licensed under the GPL version 2 or later. See > > +# the COPYING file in the top-level directory. > > + > > +error() { > > + echo "$@" >&2 > > slightly risky if $@ contains \ - using 'printf %s\\n "$*"' is nicer. > But this particular script can get away with it, as I don't see use of \ > (other than if you have a weird $0). > > > + > > +if test -n "$submodules"; then > > + { > > + git ls-files || error "git ls-files failed" > > + for sm in $submodules; do > > + (cd $sm; git ls-files) | sed "s:^:$sm/:" > > + if test "${PIPESTATUS[0]} ${PIPESTATUS[1]}" != "0 0"; then > > Could shorten to "${PIPESTATUS[*]}", as discussed in another mail, but > this works too. > > With the typo fixed, and your choice of how to handle my other two nits > (including doing nothing), > Reviewed-by: Eric Blake Fixing all of them and adding your r-b line. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > Fam