From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Date: Fri, 22 Sep 2017 09:44:02 -0700 Subject: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com> References: <20170922141138.13038-1-colin.king@canonical.com> Message-ID: <20170922094402.00001ad2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, 22 Sep 2017 15:11:38 +0100 Colin King wrote: > From: Colin Ian King > > Don't populate const array patterns on the stack, instead make it > static. Makes the object code smaller by over 60 bytes: > > Before: > text data bss dec hex filename > 1953 496 0 2449 991 i40e_diag.o > > After: > text data bss dec hex filename > 1798 584 0 2382 94e i40e_diag.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Looks good, thanks Colin! Acked-by: Jesse Brandeburg From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Date: Fri, 22 Sep 2017 16:44:02 +0000 Subject: Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size Message-Id: <20170922094402.00001ad2@intel.com> List-Id: References: <20170922141138.13038-1-colin.king@canonical.com> In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com On Fri, 22 Sep 2017 15:11:38 +0100 Colin King wrote: > From: Colin Ian King > > Don't populate const array patterns on the stack, instead make it > static. Makes the object code smaller by over 60 bytes: > > Before: > text data bss dec hex filename > 1953 496 0 2449 991 i40e_diag.o > > After: > text data bss dec hex filename > 1798 584 0 2382 94e i40e_diag.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Looks good, thanks Colin! Acked-by: Jesse Brandeburg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdIVQoj (ORCPT ); Fri, 22 Sep 2017 12:44:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:9556 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbdIVQog (ORCPT ); Fri, 22 Sep 2017 12:44:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="1198029729" Date: Fri, 22 Sep 2017 09:44:02 -0700 From: Jesse Brandeburg To: Colin King Cc: Jeff Kirsher , , , , , jesse.brandeburg@intel.com Subject: Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size Message-ID: <20170922094402.00001ad2@intel.com> In-Reply-To: <20170922141138.13038-1-colin.king@canonical.com> References: <20170922141138.13038-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2017 15:11:38 +0100 Colin King wrote: > From: Colin Ian King > > Don't populate const array patterns on the stack, instead make it > static. Makes the object code smaller by over 60 bytes: > > Before: > text data bss dec hex filename > 1953 496 0 2449 991 i40e_diag.o > > After: > text data bss dec hex filename > 1798 584 0 2382 94e i40e_diag.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Looks good, thanks Colin! Acked-by: Jesse Brandeburg