From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH i-g-t 3/6] lib/igt_fb: Add igt_cairo_image_surface_create_from_png() Date: Fri, 22 Sep 2017 15:05:44 +0300 Message-ID: <20170922120544.GM4914@intel.com> References: <20170921143933.14618-1-ville.syrjala@linux.intel.com> <20170921143933.14618-3-ville.syrjala@linux.intel.com> <20170922095259.aj5mfj6ymuqo5l6x@platvala-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08D4C6E99F for ; Fri, 22 Sep 2017 12:05:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170922095259.aj5mfj6ymuqo5l6x@platvala-desk.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Petri Latvala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMjIsIDIwMTcgYXQgMTI6NTI6NTlQTSArMDMwMCwgUGV0cmkgTGF0dmFsYSB3 cm90ZToKPiBPbiBUaHUsIFNlcCAyMSwgMjAxNyBhdCAwNTozOTozMFBNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gUmF3IHVzYWdlIG9mIGNhaXJvX2ltYWdlX3N1cmZhY2Vf Y3JlYXRlX2Zyb21fcG5nKCkgZG9lc24ndCB3b3JrCj4gPiBzaW5jZSBpdCBkb2Vzbid0IGtub3cg YWJvdXQgSUdUX0RBVEFESVIgYW5kIElHVF9TUkNESVIuIExldCdzIGV4dHJhY3QKPiA+IHRoZSBo ZWxwZXIgZnJvbSBpZ3RfcGFpbnRfaW1hZ2UoKSB0aGF0IHVzZXMgaWd0X2ZvcGVuX2RhdGEoKSAr Cj4gPiBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mcm9tX3BuZ19zdHJlYW0oKSBhbmQgY2Fs bCBpdAo+ID4gaWd0X2NhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zyb21fcG5nX2ZpbGUoKS4K PiAKPiAKPiBzL2Zyb21fcG5nX2ZpbGUvZnJvbV9wbmcvCgpBcmdoLCBzdGlsbCBvbmUgbGVmdC4g TXkgYnJhaW4ga2VwdCBzdWJjb25zY2lvdXNseSBhZGRpbmcgdGhlIF9maWxlKCkKKHRvIG1hdGNo IHRoZSBfc3RyZWFtKCkgSSBzdXBwb3NlKS4gSW4gZmFjdCBhdCBvbmUgcG9pbnQgSSB3YXMgc2Ny YXRjaGluZwpteSBoZWFkIGZvciBxdWl0ZSBhIHdoaWxlIHdvbmRlcmluZyB3aHkgaXQgd2Fzbid0 IGNvbXBpbGluZy4uLgoKPiAKPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gVGhhbmtzIGZvciBmaXhpbmcgdGhp cy4KPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTIyNDgKPiAoTm90IHN1cmUgaWYgdGhpcyBwYXRjaCBmaXhlcyBpdCB5ZXQgb3IgaWYg Q0kgc3dpdGNoIHRvIG1ha2UgaW5zdGFsbCAtZGVwbG95bWVudCBpcyBhbHNvIG5lZWRlZCkKCkht bS4gVGhlIGFzc2VydHMgSSBzZWUgdGhlcmUgc2VlbSB0byBiZSBhYm91dCBkaXNwbGF5IGNvbW1p dHMgZmFpbGluZy4KCj4ga21zX3BsYW5lX2ZpdHRpbmcgZG9lc24ndCBzZWVtIHRvIGhhdmUgYSBz ZXBhcmF0ZSBidWcgcmVwb3J0LgoKSSdtIHByZXR0eSBzdXJlIHN1Y2ggYSBidWcgcmVwb3J0IGRp ZCBleGlzdCBpbiB0aGUgcGFzdC4gQnV0IEkKd2Fzbid0IGFibGUgdG8gZmluZCBpdCBlaXRoZXIu IEkgZ3Vlc3MgaXQgd2FzIGNsb3NlZCBmb3Igc29tZSByZWFzb24uCgo+IAo+IFJldmlld2VkLWJ5 OiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNvbT4KClRoYW5rcy4KCj4gCj4g Cj4gCj4gCj4gCj4gCj4gPiAtLS0KPiA+ICBsaWIvaWd0X2ZiLmMgfCAyMSArKysrKysrKysrKysr Ky0tLS0tLS0KPiA+ICBsaWIvaWd0X2ZiLmggfCAgMSArCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAx NSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvbGli L2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gPiBpbmRleCA5NTQzNGE2OTlkY2YuLmQ0ZWFlZDcx YWNlZiAxMDA2NDQKPiA+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ID4gKysrIGIvbGliL2lndF9mYi5j Cj4gPiBAQCAtNTgzLDYgKzU4MywxOCBAQCBzdGRpb19yZWFkX2Z1bmModm9pZCAqY2xvc3VyZSwg dW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQgaW50IHNpemUpCj4gPiAgCXJldHVybiBDQUlS T19TVEFUVVNfU1VDQ0VTUzsKPiA+ICB9Cj4gPiAgCj4gPiArY2Fpcm9fc3VyZmFjZV90ICppZ3Rf Y2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZnJvbV9wbmcoY29uc3QgY2hhciAqZmlsZW5hbWUp Cj4gPiArewo+ID4gKwljYWlyb19zdXJmYWNlX3QgKmltYWdlOwo+ID4gKwlGSUxFICpmOwo+ID4g Kwo+ID4gKwlmID0gaWd0X2ZvcGVuX2RhdGEoZmlsZW5hbWUpOwo+ID4gKwlpbWFnZSA9IGNhaXJv X2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zyb21fcG5nX3N0cmVhbSgmc3RkaW9fcmVhZF9mdW5jLCBm KTsKPiA+ICsJZmNsb3NlKGYpOwo+ID4gKwo+ID4gKwlyZXR1cm4gaW1hZ2U7Cj4gPiArfQo+ID4g Kwo+ID4gIC8qKgo+ID4gICAqIGlndF9wYWludF9pbWFnZToKPiA+ICAgKiBAY3I6IGNhaXJvIGRy YXdpbmcgY29udGV4dAo+ID4gQEAgLTYwMSwxMSArNjEzLDggQEAgdm9pZCBpZ3RfcGFpbnRfaW1h Z2UoY2Fpcm9fdCAqY3IsIGNvbnN0IGNoYXIgKmZpbGVuYW1lLAo+ID4gIAljYWlyb19zdXJmYWNl X3QgKmltYWdlOwo+ID4gIAlpbnQgaW1nX3dpZHRoLCBpbWdfaGVpZ2h0Owo+ID4gIAlkb3VibGUg c2NhbGVfeCwgc2NhbGVfeTsKPiA+IC0JRklMRSogZjsKPiA+IC0KPiA+IC0JZiA9IGlndF9mb3Bl bl9kYXRhKGZpbGVuYW1lKTsKPiA+ICAKPiA+IC0JaW1hZ2UgPSBjYWlyb19pbWFnZV9zdXJmYWNl X2NyZWF0ZV9mcm9tX3BuZ19zdHJlYW0oJnN0ZGlvX3JlYWRfZnVuYywgZik7Cj4gPiArCWltYWdl ID0gaWd0X2NhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zyb21fcG5nKGZpbGVuYW1lKTsKPiA+ ICAJaWd0X2Fzc2VydChjYWlyb19zdXJmYWNlX3N0YXR1cyhpbWFnZSkgPT0gQ0FJUk9fU1RBVFVT X1NVQ0NFU1MpOwo+ID4gIAo+ID4gIAlpbWdfd2lkdGggPSBjYWlyb19pbWFnZV9zdXJmYWNlX2dl dF93aWR0aChpbWFnZSk7Cj4gPiBAQCAtNjI0LDggKzYzMyw2IEBAIHZvaWQgaWd0X3BhaW50X2lt YWdlKGNhaXJvX3QgKmNyLCBjb25zdCBjaGFyICpmaWxlbmFtZSwKPiA+ICAJY2Fpcm9fc3VyZmFj ZV9kZXN0cm95KGltYWdlKTsKPiA+ICAKPiA+ICAJY2Fpcm9fcmVzdG9yZShjcik7Cj4gPiAtCj4g PiAtCWZjbG9zZShmKTsKPiA+ICB9Cj4gPiAgCj4gPiAgLyoqCj4gPiBAQCAtODc3LDcgKzg4NCw3 IEBAIHVuc2lnbmVkIGludCBpZ3RfY3JlYXRlX2ltYWdlX2ZiKGludCBmZCwgaW50IHdpZHRoLCBp bnQgaGVpZ2h0LAo+ID4gIAl1aW50MzJfdCBmYl9pZDsKPiA+ICAJY2Fpcm9fdCAqY3I7Cj4gPiAg Cj4gPiAtCWltYWdlID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZnJvbV9wbmcoZmlsZW5h bWUpOwo+ID4gKwlpbWFnZSA9IGlndF9jYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mcm9tX3Bu ZyhmaWxlbmFtZSk7Cj4gPiAgCWlndF9hc3NlcnQoY2Fpcm9fc3VyZmFjZV9zdGF0dXMoaW1hZ2Up ID09IENBSVJPX1NUQVRVU19TVUNDRVNTKTsKPiA+ICAJaWYgKHdpZHRoID09IDApCj4gPiAgCQl3 aWR0aCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X3dpZHRoKGltYWdlKTsKPiA+IGRpZmYgLS1n aXQgYS9saWIvaWd0X2ZiLmggYi9saWIvaWd0X2ZiLmgKPiA+IGluZGV4IGExOTNhMWU3NTcyZC4u M2Y1NDkwMzZhYmM1IDEwMDY0NAo+ID4gLS0tIGEvbGliL2lndF9mYi5oCj4gPiArKysgYi9saWIv aWd0X2ZiLmgKPiA+IEBAIC0xMzYsNiArMTM2LDcgQEAgdWludDY0X3QgaWd0X2ZiX3RpbGluZ190 b19tb2QodWludDY0X3QgdGlsaW5nKTsKPiA+ICAKPiA+ICAvKiBjYWlyby1iYXNlZCBwYWludGlu ZyAqLwo+ID4gIGNhaXJvX3N1cmZhY2VfdCAqaWd0X2dldF9jYWlyb19zdXJmYWNlKGludCBmZCwg c3RydWN0IGlndF9mYiAqZmIpOwo+ID4gK2NhaXJvX3N1cmZhY2VfdCAqaWd0X2NhaXJvX2ltYWdl X3N1cmZhY2VfY3JlYXRlX2Zyb21fcG5nKGNvbnN0IGNoYXIgKmZpbGVuYW1lKTsKPiA+ICBjYWly b190ICppZ3RfZ2V0X2NhaXJvX2N0eChpbnQgZmQsIHN0cnVjdCBpZ3RfZmIgKmZiKTsKPiA+ICB2 b2lkIGlndF9wYWludF9jb2xvcihjYWlyb190ICpjciwgaW50IHgsIGludCB5LCBpbnQgdywgaW50 IGgsCj4gPiAgCQkJIGRvdWJsZSByLCBkb3VibGUgZywgZG91YmxlIGIpOwo+ID4gLS0gCj4gPiAy LjEzLjUKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK