From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] sched: Cleanup task->state printing
Date: Fri, 22 Sep 2017 14:40:22 +0200 [thread overview]
Message-ID: <20170922124022.GA234@x4> (raw)
In-Reply-To: <20170922115430.moipv7sts6v4t7sw@hirez.programming.kicks-ass.net>
On 2017.09.22 at 13:54 +0200, Peter Zijlstra wrote:
> On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote:
> > > It seems to work. Simply returning "I (idle)" from get_task_state() in
> > > fs/proc/array.c when the state is TASK_IDLE does the trick.
> > > I've tested top, htop and ps.
>
> I ended up with the below; there was quite a lot of inconsistent state
> printing around it seems.
>
> I should probably split this thing into a bunch of patches :/
>
> Alongside an explicit idle state, this also exposes TASK_PARKED,
> although arguably we could map that to idle too. Opinions?
Looks good to me and works as expected.
Many thanks.
--
Markus
next prev parent reply other threads:[~2017-09-22 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 7:36 Worker threads in D state since c5a94a618e7ac86 (workqueue: Use TASK_IDLE) Markus Trippelsdorf
2017-09-11 13:11 ` Tejun Heo
2017-09-11 14:21 ` Markus Trippelsdorf
2017-09-21 11:08 ` Markus Trippelsdorf
2017-09-21 12:30 ` Peter Zijlstra
2017-09-21 14:41 ` Markus Trippelsdorf
2017-09-22 9:35 ` Markus Trippelsdorf
2017-09-22 11:54 ` [RFC][PATCH] sched: Cleanup task->state printing Peter Zijlstra
2017-09-22 12:40 ` Markus Trippelsdorf [this message]
2017-09-22 14:12 ` Steven Rostedt
2017-09-22 15:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922124022.GA234@x4 \
--to=markus@trippelsdorf.de \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.