From: Oleg Nesterov <oleg@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Chris Salls <chrissalls5@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
"security@kernel.org" <security@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Tycho Andersen <tycho@docker.com>
Subject: Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()
Date: Fri, 22 Sep 2017 17:22:29 +0200 [thread overview]
Message-ID: <20170922152229.GA19152@redhat.com> (raw)
In-Reply-To: <CAGXu5jL6DXNArYnLkd4PhgVTMgprZF6pKx2euiCg-f9kFdexTQ@mail.gmail.com>
On 09/21, Kees Cook wrote:
>
> On Thu, Sep 21, 2017 at 3:57 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 09/20, Kees Cook wrote:
> >>
> >> Given how reference counting is done for filters, I'd be happier with
> >> leaving the get_seccomp_filter() as-is,
> >
> > No, please note that filter != tsk->seccomp.filter, get_seccomp_filter()
> > won't work.
>
> Ah yes, sorry, you're right.
>
> >> (i.e. don't open-code
> >> the refcount_inc()).
> >
> > agreed, probably another __get_seccomp_filter(filter) makes sense, especially
> > if we do other changes like get_nth().
> >
> > But imo not in this fix.
>
> Regardless, whatever lands will need backport adjustment for
> refcount_*/atomic_* in -stable.
yes, but this adjustment is trivial, and we will need it whatever we do
in this fix,
> Can you resend the two patches; I can send the backport to -stable manually...
Not sure I understand... Do you mean this fix + untested "introduce get_nth_filter()" ?
Can't we push this simple fix first? Then we can discuss the cleanups. Besides,
the 2nd patch connects to Tycho's "[PATCH] ptrace, seccomp: add support for
retrieving seccomp flags", otherwise it could be more simple.
Oleg.
next prev parent reply other threads:[~2017-09-22 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN-hQdds6zkYaGRJTrS5KOorvopoYnP4vBEfoKntS_8y4884Aw@mail.gmail.com>
2017-09-20 12:56 ` [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter() Oleg Nesterov
2017-09-20 13:04 ` Oleg Nesterov
2017-09-20 13:37 ` Tycho Andersen
2017-09-20 15:59 ` introduce get_nth_filter() Oleg Nesterov
2017-09-20 16:14 ` Oleg Nesterov
2017-09-20 18:40 ` [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter() Kees Cook
2017-09-21 11:31 ` Oleg Nesterov
2017-09-20 13:26 ` Tycho Andersen
2017-09-20 18:36 ` Kees Cook
2017-09-21 10:57 ` Oleg Nesterov
2017-09-21 19:51 ` Kees Cook
2017-09-22 15:22 ` Oleg Nesterov [this message]
2017-09-22 15:25 ` Tycho Andersen
2017-09-26 20:15 ` Tycho Andersen
2017-09-27 6:07 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922152229.GA19152@redhat.com \
--to=oleg@redhat.com \
--cc=chrissalls5@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=security@kernel.org \
--cc=tycho@docker.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.