From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Carlo Caione <carlo@caione.org>,
alan@linux.intel.com, Michael Turquette <mturquette@baylibre.com>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Linux Upstreaming Team <linux@endlessm.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH v3] clk: x86: Do not gate clocks enabled by the firmware
Date: Fri, 22 Sep 2017 14:36:14 -0700 [thread overview]
Message-ID: <20170922213614.GA10927@fury> (raw)
In-Reply-To: <1505721917.25945.275.camel@linux.intel.com>
On Mon, Sep 18, 2017 at 11:05:17AM +0300, Andy Shevchenko wrote:
> On Thu, 2017-09-07 at 16:51 -0500, Pierre-Louis Bossart wrote:
> >
> >
>
> > >
> > > Looks like the same code that was initially used as a reference for
> > > support of PMC clocks in the clock framework, so now we have 2
> > > drivers
> > > programming the same PMC hardware, not so good. We'd probably have
> > > to
> > > move the atomisp driver to move to clk_get/prepare/enable instead
> > > of
> > > the old vlv2_clck_get?
> >
> > See attached an untested change to show the idea on moving to the clk
> > API and get feedback (I am not a camera guy, just trying to help -
> > compile-tested/checkpatch only).
> > This code *should* enable the same functionality using existing hooks
> > in
> > the kernel (and handle the BYT/CHT clocking difference as a bonus).
> > I am sure Andy will have plenty of comments :-)
>
> I have one comment: nice clean up!
>
> AtomISP is a *horrible* mess.
>
Pierre, will you be submitting this patch officially now that you have a
tested-by?
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-09-22 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 8:23 [PATCH v3] clk: x86: Do not gate clocks enabled by the firmware Carlo Caione
2017-07-18 23:24 ` Stephen Boyd
2017-09-07 9:22 ` Carlo Caione
2017-09-07 11:59 ` Pierre-Louis Bossart
2017-09-07 21:51 ` Pierre-Louis Bossart
2017-09-08 8:05 ` Carlo Caione
2017-09-18 8:05 ` Andy Shevchenko
2017-09-22 21:36 ` Darren Hart [this message]
2017-09-22 21:47 ` Carlo Caione
2017-09-22 22:17 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922213614.GA10927@fury \
--to=dvhart@infradead.org \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=eballetbo@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.