From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 24 Sep 2017 17:38:43 -0400 Subject: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root In-Reply-To: <20170924210736.13335-3-tuomas.tynkkynen@iki.fi> References: <20170924210736.13335-1-tuomas.tynkkynen@iki.fi> <20170924210736.13335-3-tuomas.tynkkynen@iki.fi> Message-ID: <20170924213843.GC29028@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > The previous commit fixed a problem in FAT code where going back to the > root directory using '..' wouldn't work correctly on FAT12 or FAT16. > Add a test to exercise this case (which was once fixed in commit > 18a10d46f26 "fat: handle paths that include ../" but reintroduced due to > the directory iterator refactoring). > > This test only very barely catches the problem - without the fix the > size command still gives valid output but the additional spurious > "Invalid FAT entry" error message makes it not get caught in the > 'egrep -A3 ' output. I tried to make a proper test that grows the root > directory to two clusters lots of with dummy files but that causes the > write tests to crash the sandbox totally... Can you post, unrelated, the code that totally crashed sandbox? Maybe that's a problem we need to fix too :) Otherwise fine, but we need to update the expected results. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: