From: Fam Zheng <famz@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end callback
Date: Mon, 25 Sep 2017 10:27:55 +0800 [thread overview]
Message-ID: <20170925022755.GA22980@lemon.lan> (raw)
In-Reply-To: <20170923111411.18626-2-el13635@mail.ntua.gr>
On Sat, 09/23 14:14, Manos Pitsidianakis wrote:
> BlockDriverState has a bdrv_co_drain() callback but no equivalent for
> the end of the drain. The throttle driver (block/throttle.c) needs a way
> to mark the end of the drain in order to toggle io_limits_disabled
> correctly, thus bdrv_co_drain_end is needed.
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-09-25 2:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 11:14 [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Manos Pitsidianakis
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end callback Manos Pitsidianakis
2017-09-25 2:27 ` Fam Zheng [this message]
2017-09-25 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin Manos Pitsidianakis
2017-09-25 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks Manos Pitsidianakis
2017-09-26 10:02 ` [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Stefan Hajnoczi
2017-09-26 11:00 ` Stefan Hajnoczi
2017-09-26 12:44 ` Manos Pitsidianakis
2017-09-29 12:25 ` Kevin Wolf
2017-10-13 12:27 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925022755.GA22980@lemon.lan \
--to=famz@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.