From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] docker: add installation to build tests
Date: Mon, 25 Sep 2017 11:09:12 +0800 [thread overview]
Message-ID: <20170925030912.GC22980@lemon.lan> (raw)
In-Reply-To: <1506095371-23160-1-git-send-email-pbonzini@redhat.com>
On Fri, 09/22 17:49, Paolo Bonzini wrote:
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 6865689..1522aab 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -36,3 +36,11 @@ build_qemu()
> $QEMU_SRC/configure $config_opts
> make $MAKEFLAGS
> }
> +
> +install_qemu()
> +{
> + make install $MAKEFLAGS DESTDIR=$PWD/=destdir
Why provide DESTDIR? build_qemu already has "--prefix=$INSTALL_DIR", can a
simple "make install $MAKEFLAGS" work? Is there a permission problem?
> + ret=$?
> + rm -rf $PWD/=destdir
Why is this cleanup needed given the container will go away anyway?
Fam
next prev parent reply other threads:[~2017-09-25 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 15:49 [Qemu-devel] [PATCH v2] docker: add installation to build tests Paolo Bonzini
2017-09-25 3:09 ` Fam Zheng [this message]
2017-09-25 9:11 ` Paolo Bonzini
2017-09-25 11:14 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925030912.GC22980@lemon.lan \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.