From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4] dmaengine: qcom-bam: Process multiple pending descriptors Date: Mon, 25 Sep 2017 11:50:55 +0530 Message-ID: <20170925062055.GA30097@localhost> References: <1503932424-4527-1-git-send-email-sricharan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga01.intel.com ([192.55.52.88]:53076 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841AbdIYGRR (ORCPT ); Mon, 25 Sep 2017 02:17:17 -0400 Content-Disposition: inline In-Reply-To: <1503932424-4527-1-git-send-email-sricharan@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sricharan R Cc: absahu@codeaurora.org, andy.gross@linaro.org, david.brown@linaro.org, dan.j.williams@intel.com, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine-owner@vger.kernel.org, stanimir.varbanov@linaro.org, architt@codeaurora.org On Mon, Aug 28, 2017 at 08:30:24PM +0530, Sricharan R wrote: > The bam dmaengine has a circular FIFO to which we > add hw descriptors that describes the transaction. > The FIFO has space for about 4096 hw descriptors. > > Currently we add one descriptor and wait for it to > complete with interrupt and then add the next pending > descriptor. In this way, the FIFO is underutilized > since only one descriptor is processed at a time, although > there is space in FIFO for the BAM to process more. > > Instead keep adding descriptors to FIFO till its full, > that allows BAM to continue to work on the next descriptor > immediately after signalling completion interrupt for the > previous descriptor. > > Also when the client has not set the DMA_PREP_INTERRUPT for > a descriptor, then do not configure BAM to trigger a interrupt > upon completion of that descriptor. This way we get a interrupt > only for the descriptor for which DMA_PREP_INTERRUPT was > requested and there signal completion of all the previous completed > descriptors. So we still do callbacks for all requested descriptors, > but just that the number of interrupts are reduced. > > CURRENT: > > ------ ------- --------------- > |DES 0| |DESC 1| |DESC 2 + INT | > ------ ------- --------------- > | | | > | | | > INTERRUPT: (INT) (INT) (INT) > CALLBACK: (CB) (CB) (CB) > > MTD_SPEEDTEST READ PAGE: 3560 KiB/s > MTD_SPEEDTEST WRITE PAGE: 2664 KiB/s > IOZONE READ: 2456 KB/s > IOZONE WRITE: 1230 KB/s > > bam dma interrupts (after tests): 96508 > > CHANGE: > > ------ ------- ------------- > |DES 0| |DESC 1 |DESC 2 + INT | > ------ ------- -------------- > | > | > (INT) > (CB for 0, 1, 2) > > MTD_SPEEDTEST READ PAGE: 3860 KiB/s > MTD_SPEEDTEST WRITE PAGE: 2837 KiB/s > IOZONE READ: 2677 KB/s > IOZONE WRITE: 1308 KB/s > > bam dma interrupts (after tests): 58806 Applied, thanks. Sorry for the delay, bad timing I guess :) -- ~Vinod