From: Brandon Williams <bmwill@google.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH 3/4] Document submodule_to_gitdir
Date: Mon, 25 Sep 2017 10:25:24 -0700 [thread overview]
Message-ID: <20170925172524.GC35385@google.com> (raw)
In-Reply-To: <20170925155927.32328-4-hanwen@google.com>
On 09/25, Han-Wen Nienhuys wrote:
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
> submodule.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/submodule.c b/submodule.c
> index b12600fc7..b66c23f5d 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1997,6 +1997,9 @@ const char *get_superproject_working_tree(void)
> return ret;
> }
>
> +/* Put the gitdir for a submodule (given relative to the main repository worktree)
> + * into `buf`, or return -1 on error.
> + */
Same nit as in patch [2/4]
> int submodule_to_gitdir(struct strbuf *buf, const char *submodule)
> {
> const struct submodule *sub;
> --
> 2.14.1.821.g8fa685d3b7-goog
>
--
Brandon Williams
next prev parent reply other threads:[~2017-09-25 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 15:59 [PATCH 0/4] Assorted comment fixes Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 1/4] Fix typo in submodule.h Han-Wen Nienhuys
2017-09-25 15:59 ` [PATCH 2/4] Clarify return value ownership of real_path and read_gitfile_gently Han-Wen Nienhuys
2017-09-25 17:24 ` Brandon Williams
2017-09-26 5:01 ` Junio C Hamano
2017-09-25 15:59 ` [PATCH 3/4] Document submodule_to_gitdir Han-Wen Nienhuys
2017-09-25 17:25 ` Brandon Williams [this message]
2017-09-25 15:59 ` [PATCH 4/4] Move documentation of string_list into string-list.h Han-Wen Nienhuys
2017-09-25 17:40 ` Brandon Williams
2017-09-25 20:05 ` Stefan Beller
2017-09-27 15:59 ` Andrey Rybak
2017-09-26 5:06 ` Junio C Hamano
2017-09-26 5:22 ` Junio C Hamano
2017-09-26 11:22 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925172524.GC35385@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.