Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 25 Sep 2017 17:06:01 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:

> @Connie
> I would also like to have an account. 

Done (for both of you).

> I would also like to do a
> v2 of this somewhere in the not too distant future. I intend
> to address the issues pointed out by you here (chpid_type,
> cu_type). Another question is whether this should go under
> hw/misc/ like the pci-testdev? ccw-testdev would also probably
> be a better file name (that ccw-tester) regardless of in which
> folder does this belong. 

Probably not a bad idea to follow pci here.

> One more thing I am considering for
> v2 is this make it extensible argument. I had something like
> mode on my mind from the very beginning (fib would be one mode).
> The idea was to provide a control ccw for setting/getting the mode
> (something like virtio) as well as a device property for setting
> the initial mode (so that guest does not have to know about it).

Yes, a control ccw sounds nice, we should just make sure that it
doesn't collide with future tests (e.g. if we want to do some channel
program fuzzing). Alternatively, this could be controled by a diagnose,
which would be out of band (we can use a high function code for diag
500 that is unlikely to collide with future extensions).