From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 25 Sep 2017 14:07:28 -0500 Subject: [Cluster-devel] [PATCH] dlm/recoverd: recheck kthread_should_stop() before schedule() In-Reply-To: <1506325670-1239-1-git-send-email-gqjiang@suse.com> References: <1506325670-1239-1-git-send-email-gqjiang@suse.com> Message-ID: <20170925190728.GA16497@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Sep 25, 2017 at 03:47:50PM +0800, Guoqing Jiang wrote: > Call schedule() here could make the thread miss wake > up from kthread_stop(), so it is better to recheck > kthread_should_stop() before call schedule(), a symptom > happened when I run indefinite test (which mostly created > clustered raid1, assemble it in other nodes, then stop > them) of clustered raid. Thanks, I put this into the next branch in linux-dlm (which I also moved onto -rc2.)