From: Andi Kleen <ak@linux.intel.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
namhyung@kernel.org, adrian.hunter@intel.com,
lukasz.odzioba@intel.com
Subject: Re: [PATCH RFC V3 5/5] perf top: switch back to overwrite mode
Date: Mon, 25 Sep 2017 13:36:04 -0700 [thread overview]
Message-ID: <20170925203604.GP4311@tassilo.jf.intel.com> (raw)
In-Reply-To: <1506370988-56587-6-git-send-email-kan.liang@intel.com>
On Mon, Sep 25, 2017 at 01:23:08PM -0700, kan.liang@intel.com wrote:
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 6a0d7ff..ef0b6b1 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -723,7 +723,10 @@ perf_mmap__read(struct perf_mmap *md, bool check_messup, u64 start,
> * In either case, truncate and restart at 'end'.
> */
> if (diff > md->mask / 2 || diff < 0) {
> - fprintf(stderr, "WARNING: failed to keep up with mmap data.\n");
> + WARN_ONCE(1, "WARNING: failed to keep up with mmap data.\n"
> + "Please try increasing the period (-c) or\n"
> + "decreasing the freq (-F) or\n"
> + "limiting the number of CPUs");
should suggest -C too
"limiting the number of CPUs (-C)");
-Andi
next prev parent reply other threads:[~2017-09-25 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 20:23 [PATCH RFC V3 0/5] perf top optimization kan.liang
2017-09-25 20:23 ` [PATCH RFC V3 1/5] perf tools: lock to protect namespaces and comm list kan.liang
2017-09-25 20:23 ` [PATCH RFC V3 2/5] perf tools: lock to protect comm_str rb tree kan.liang
2017-09-25 20:23 ` [PATCH RFC V3 3/5] perf top: implement multithreading for perf_event__synthesize_threads kan.liang
2017-09-27 11:44 ` Jiri Olsa
2017-09-25 20:23 ` [PATCH RFC V3 4/5] perf top: add option to set the number of thread for event synthesize kan.liang
2017-09-25 20:23 ` [PATCH RFC V3 5/5] perf top: switch back to overwrite mode kan.liang
2017-09-25 20:36 ` Andi Kleen [this message]
2017-09-27 12:00 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925203604.GP4311@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.odzioba@intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.