All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory
Date: Mon, 25 Sep 2017 16:10:55 -0700	[thread overview]
Message-ID: <20170925231055.GA3053@ubuntu> (raw)
In-Reply-To: <CAJZ5v0hv3T7L0c5URrVHC=H5V3h+W7OLRXVMVXLQf-VuTT-E+Q@mail.gmail.com>

On 25-09-17, 00:44, Rafael J. Wysocki wrote:
> On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > The command:
> >
> >  $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
> >
> > is incorrectly picking maintainers from Hibernation and Suspend to RAM
> > as well, simply because the entries in MAINTAINERS file contains the
> > entire power directory. Though the only concerning file is main.c
> > really.
> 
> No, it is not the only one.  The others are common.c, trace.c,
> wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
> overlooked any).
> 
> I'm not actually sure how to fix this issue other than by listing all
> of the files in question directly in there.

Should I just use *.c for now? Yeah, that will still cover lot more files, but
at least the directories, like OPP, are not going to show those maintainers.

Or I was actually thinking of moving the entire OPP directory out of
drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will
that be okay?

-- 
viresh

  reply	other threads:[~2017-09-25 23:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 15:58 [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory Viresh Kumar
2017-09-24 22:44 ` Rafael J. Wysocki
2017-09-25 23:10   ` Viresh Kumar [this message]
2017-09-25 23:18     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925231055.GA3053@ubuntu \
    --to=viresh.kumar@linaro.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.