From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 26 Sep 2017 08:10:30 +0200 (CEST) Received: from verein.lst.de ([213.95.11.211]:45534 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990515AbdIZGKYCzknz (ORCPT ); Tue, 26 Sep 2017 08:10:24 +0200 Received: by newverein.lst.de (Postfix, from userid 2407) id D34909EDA3; Tue, 26 Sep 2017 08:10:19 +0200 (CEST) Date: Tue, 26 Sep 2017 08:10:19 +0200 From: Christoph Hellwig To: =?utf-8?B?6ZmI5Y2O5omN?= Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andrew Morton , Fuxin Zhang , linux-kernel , Ralf Baechle , James Hogan , linux-mips , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi , Roland Dreier , Pawel Osciak , Kyungmin Park , Michael Chan , Benjamin Herrenschmidt , Ivan Mikhaylov , Tariq Toukan , Andy Gross , "Mark A . Greer" , Robert Baldyga , stable Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Message-ID: <20170926061019.GA6416@lst.de> References: <1506332766-23966-1-git-send-email-chenhc@lemote.com> <20170925125107.GC8130@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 60151 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: hch@lst.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Sep 26, 2017 at 09:48:01AM +0800, 陈华才 wrote: > Hi, Christoph, > > Can I put the declaration in asm/dma-coherence.h? Generally something not expose to the rest of the kernel (that is not in arch/mips/include/) would be preferred, but in the end the architecture maintainer will have to decide. > And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so. No, I asked you to converted everything to pass the struct device and cc the driver maintainers. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Date: Tue, 26 Sep 2017 08:10:19 +0200 Message-ID: <20170926061019.GA6416@lst.de> References: <1506332766-23966-1-git-send-email-chenhc@lemote.com> <20170925125107.GC8130@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: =?utf-8?B?6ZmI5Y2O5omN?= Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andrew Morton , Fuxin Zhang , linux-kernel , Ralf Baechle , James Hogan , linux-mips , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi , Roland Dreier , Pawel Osciak , Kyungmin Park , Michael Chan , Benjamin Herrenschmidt , Ivan Mikhaylov , Tariq Toukan List-Id: linux-scsi@vger.kernel.org On Tue, Sep 26, 2017 at 09:48:01AM +0800, 陈华才 wrote: > Hi, Christoph, > > Can I put the declaration in asm/dma-coherence.h? Generally something not expose to the rest of the kernel (that is not in arch/mips/include/) would be preferred, but in the end the architecture maintainer will have to decide. > And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so. No, I asked you to converted everything to pass the struct device and cc the driver maintainers.