From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 68CA52095E518 for ; Mon, 25 Sep 2017 23:29:23 -0700 (PDT) Date: Tue, 26 Sep 2017 08:32:34 +0200 From: Christoph Hellwig Subject: Re: [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path Message-ID: <20170926063234.GA6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-4-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170925231404.32723-4-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jeff Layton , Jan Kara , "Darrick J. Wong" , Dave Chinner , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, "J. Bruce Fields" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linux-xfs@vger.kernel.org, Christoph Hellwig List-ID: We can't just take locking one level up, as we need differnet locking for different kinds of I/O. I think you probably want an IOCB_DAX flag to check IS_DAX once and then stick to it, similar to what we do for direct I/O. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:55865 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935245AbdIZGcg (ORCPT ); Tue, 26 Sep 2017 02:32:36 -0400 Date: Tue, 26 Sep 2017 08:32:34 +0200 From: Christoph Hellwig Subject: Re: [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path Message-ID: <20170926063234.GA6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-4-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170925231404.32723-4-ross.zwisler@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Ross Zwisler Cc: Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J. Wong" , "J. Bruce Fields" , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org We can't just take locking one level up, as we need differnet locking for different kinds of I/O. I think you probably want an IOCB_DAX flag to check IS_DAX once and then stick to it, similar to what we do for direct I/O. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Sep 2017 08:32:34 +0200 From: Christoph Hellwig To: Ross Zwisler Cc: Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J. Wong" , "J. Bruce Fields" , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path Message-ID: <20170926063234.GA6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-4-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170925231404.32723-4-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: We can't just take locking one level up, as we need differnet locking for different kinds of I/O. I think you probably want an IOCB_DAX flag to check IS_DAX once and then stick to it, similar to what we do for direct I/O. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org