From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F5622095E518 for ; Mon, 25 Sep 2017 23:33:40 -0700 (PDT) Date: Tue, 26 Sep 2017 08:36:50 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag Message-ID: <20170926063650.GE6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-3-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170925231404.32723-3-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jeff Layton , Jan Kara , "Darrick J. Wong" , Dave Chinner , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, "J. Bruce Fields" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linux-xfs@vger.kernel.org, Christoph Hellwig List-ID: On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote: > Currently only the blocksize is checked, but we should really be calling > bdev_dax_supported() which also tests to make sure we can get a > struct dax_device and that the dax_direct_access() path is working. > > This is the same check that we do for the "-o dax" mount option in > xfs_fs_fill_super(). > > Signed-off-by: Ross Zwisler > Reviewed-by: Christoph Hellwig I think we just want to pick this up ASAP. And between my vague memoried and that reviewed-by tag it already was part of a different series, wasn't it? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:55933 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934342AbdIZGgw (ORCPT ); Tue, 26 Sep 2017 02:36:52 -0400 Date: Tue, 26 Sep 2017 08:36:50 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag Message-ID: <20170926063650.GE6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-3-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170925231404.32723-3-ross.zwisler@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Ross Zwisler Cc: Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J. Wong" , "J. Bruce Fields" , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote: > Currently only the blocksize is checked, but we should really be calling > bdev_dax_supported() which also tests to make sure we can get a > struct dax_device and that the dax_direct_access() path is working. > > This is the same check that we do for the "-o dax" mount option in > xfs_fs_fill_super(). > > Signed-off-by: Ross Zwisler > Reviewed-by: Christoph Hellwig I think we just want to pick this up ASAP. And between my vague memoried and that reviewed-by tag it already was part of a different series, wasn't it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Sep 2017 08:36:50 +0200 From: Christoph Hellwig To: Ross Zwisler Cc: Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J. Wong" , "J. Bruce Fields" , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag Message-ID: <20170926063650.GE6870@lst.de> References: <20170925231404.32723-1-ross.zwisler@linux.intel.com> <20170925231404.32723-3-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170925231404.32723-3-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote: > Currently only the blocksize is checked, but we should really be calling > bdev_dax_supported() which also tests to make sure we can get a > struct dax_device and that the dax_direct_access() path is working. > > This is the same check that we do for the "-o dax" mount option in > xfs_fs_fill_super(). > > Signed-off-by: Ross Zwisler > Reviewed-by: Christoph Hellwig I think we just want to pick this up ASAP. And between my vague memoried and that reviewed-by tag it already was part of a different series, wasn't it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org