All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Chris Gorman <chrisjohgorman@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: pinctrl: intel fixed typo
Date: Tue, 26 Sep 2017 09:46:53 +0300	[thread overview]
Message-ID: <20170926064653.GF4630@lahna.fi.intel.com> (raw)
In-Reply-To: <1506364916-21349-1-git-send-email-chrisjohgorman@gmail.com>

On Mon, Sep 25, 2017 at 02:41:56PM -0400, Chris Gorman wrote:
> fixed typo in comment for north_community
> 
> Signed-off-by: Chris Gorman <chrisjohgorman@gmail.com>

Please fix title to be something like "pinctrl: cherryview: Fix typo
in comment". And also in the commit message, start it with capital
letter and end with "." like:

Fixed typo on comment for north_community.

The patch itself looks good.

Thanks!

> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 04e929f..8d50eae 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -491,7 +491,7 @@ static const struct chv_community north_community = {
>  	.ngpio_ranges = ARRAY_SIZE(north_gpio_ranges),
>  	.ngpios = ARRAY_SIZE(north_pins),
>  	/*
> -	 * North community can benerate GPIO interrupts only for the first
> +	 * North community can generate GPIO interrupts only for the first
>  	 * 8 interrupts. The upper half (8-15) can only be used to trigger
>  	 * GPEs.
>  	 */
> -- 
> 2.7.4

      reply	other threads:[~2017-09-26  6:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 18:41 [PATCH] Drivers: pinctrl: intel fixed typo Chris Gorman
2017-09-26  6:46 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926064653.GF4630@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=chrisjohgorman@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.