All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 2/2] Staging: rtl8723bs: core: Code clean up
Date: Tue, 26 Sep 2017 09:41:38 +0200	[thread overview]
Message-ID: <20170926074138.GA26263@kroah.com> (raw)
In-Reply-To: <8813107f1cbbc593f55422ef905c4d5cfb575206.1506092223.git.georgiana.chelu93@gmail.com>

On Fri, Sep 22, 2017 at 08:04:52AM -0700, Georgiana Chelu wrote:
> Clean the code to improve the coding style.
> 
> Fix minor issues reported by checkpatch.pl:
> * CHECK: Alignment should match open parenthesis
> * CHECK: Logical continuations should be on the previous line
> * WARNING: line over 80 characters

That's a lot of different things to be doing all in one patch.  Please
break this up into "one type of thing" per patch.

And no, "fix all coding style issues" is not "one thing" :)

thanks,

greg k-h


  reply	other threads:[~2017-09-26  7:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 15:04 [PATCH v2 0/2] Staging: rtl8723bs: core: Fix coccinelle warning Georgiana Chelu
2017-09-22 15:04 ` [PATCH v2 1/2] Staging: rtl8723bs: core: Remove boolean comparison Georgiana Chelu
2017-09-22 15:04 ` [PATCH v2 2/2] Staging: rtl8723bs: core: Code clean up Georgiana Chelu
2017-09-26  7:41   ` Greg Kroah-Hartman [this message]
2017-09-26 16:11     ` Georgiana Chelu
2017-09-26 16:13       ` Georgiana Chelu
2017-09-26 16:40         ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926074138.GA26263@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=georgiana.chelu93@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.