All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: devesh.sharma@broadcom.com, dledford@redhat.com,
	sean.hefty@intel.com, hal.rosenstock@gmail.com,
	yuval.shaia@oracle.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines
Date: Tue, 26 Sep 2017 11:44:35 +0300	[thread overview]
Message-ID: <20170926084435.GC6816@mtr-leonro.local> (raw)
In-Reply-To: <48e72f72b25c067588b3da9142c7849636615df9.1506410780.git.arvind.yadav.cs@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
>                Add same changes for 'ocrdma_hw.c'
>

Two notes,
1. Please send similar changes as a patchset and not as a standalone patches.
2. These patches "\n" are not needed, see my response to mlx5 patch.

Thanks,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-09-26  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  7:29 [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav
2017-09-26  8:44 ` Leon Romanovsky [this message]
     [not found] ` <48e72f72b25c067588b3da9142c7849636615df9.1506410780.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-26  7:52   ` Yuval Shaia
2017-09-26  7:52     ` Yuval Shaia
2017-09-27 14:21   ` Doug Ledford
2017-09-27 14:21     ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926084435.GC6816@mtr-leonro.local \
    --to=leon@kernel.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=devesh.sharma@broadcom.com \
    --cc=dledford@redhat.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.