From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: ALPS - remove redundant unlikely()
Date: Tue, 26 Sep 2017 11:57:06 +0200 [thread overview]
Message-ID: <20170926095706.GR22190@pali> (raw)
In-Reply-To: <20170926092951.26721-1-tklauser@distanz.ch>
On Tuesday 26 September 2017 11:29:51 Tobias Klauser wrote:
> IS_ERR_OR_NULL() already implies unlikely(), so it can be omitted.
Hi Tobias! Exactly same patch was sent 2 years ago. See discussion about
it why it is not a good idea to apply it:
https://lists.gt.net/linux/kernel/2269724
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/input/mouse/alps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 850b00e3ad8e..2aaceb1e9d4f 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1486,7 +1486,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
> /* On V2 devices the DualPoint Stick reports bare packets */
> dev = priv->dev2;
> dev2 = psmouse->dev;
> - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
> + } else if (IS_ERR_OR_NULL(priv->dev3)) {
> /* Register dev3 mouse if we received PS/2 packet first time */
> if (!IS_ERR(priv->dev3))
> psmouse_queue_work(psmouse, &priv->dev3_register_work,
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-09-26 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:29 [PATCH] Input: ALPS - remove redundant unlikely() Tobias Klauser
2017-09-26 9:57 ` Pali Rohár [this message]
2017-09-26 10:11 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926095706.GR22190@pali \
--to=pali.rohar@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.