From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: dvhart@infradead.org, Andy Shevchenko <andy.shevchenko@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, quasisec@google.com
Subject: Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check
Date: Tue, 26 Sep 2017 22:11:56 +0200 [thread overview]
Message-ID: <201709262211.57222@pali> (raw)
In-Reply-To: <4178d2bdfc69c94fe4972fee7b97b08202890e66.1506451187.git.mario.limonciello@dell.com>
[-- Attachment #1: Type: Text/Plain, Size: 264 bytes --]
On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote:
> + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
Should not be this memcmp? IIRC we want to compare that buffer is equal
to some bytes, right?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-09-26 20:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 18:49 [PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-09-26 18:49 ` [PATCH v2 01/14] platform/x86: dell-wmi: label driver as handling notifications Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes Mario Limonciello
2017-09-27 17:40 ` Darren Hart
2017-09-27 17:44 ` Mario.Limonciello
2017-09-27 17:44 ` Mario.Limonciello
2017-09-27 17:58 ` Darren Hart
2017-09-29 14:59 ` kbuild test robot
2017-09-29 14:59 ` kbuild test robot
2017-09-26 18:50 ` [PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor GUID modalias Mario Limonciello
2017-09-27 17:21 ` Darren Hart
2017-09-27 17:30 ` Mario.Limonciello
2017-09-27 17:30 ` Mario.Limonciello
2017-09-27 17:44 ` Darren Hart
2017-09-26 18:50 ` [PATCH v2 04/14] platform/x86: dell-smbios: Add pr_fmt definition to driver Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 05/14] platform/x86: wmi: sort include list Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 06/14] platform/x86: wmi: Cleanup exit routine in reverse order of init Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 07/14] platform/x86: wmi: destroy on cleanup rather than unregister Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 08/14] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Mario Limonciello
2017-09-27 22:18 ` Darren Hart
2017-09-26 18:50 ` [PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi-smbios Mario Limonciello
2017-09-26 20:06 ` Pali Rohár
2017-09-26 20:18 ` Mario.Limonciello
2017-09-26 20:18 ` Mario.Limonciello
2017-09-27 22:30 ` Darren Hart
2017-09-29 14:53 ` kbuild test robot
2017-09-29 14:53 ` kbuild test robot
2017-09-29 15:33 ` kbuild test robot
2017-09-29 15:33 ` kbuild test robot
2017-09-26 18:50 ` [PATCH v2 10/14] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 11/14] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 12/14] platform/x86: dell-wmi-smbios: introduce character device for userspace Mario Limonciello
2017-09-26 19:04 ` Andy Shevchenko
2017-09-26 20:10 ` Pali Rohár
2017-09-26 20:16 ` Mario.Limonciello
2017-09-26 20:16 ` Mario.Limonciello
2017-09-26 18:50 ` [PATCH v2 13/14] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios Mario Limonciello
2017-09-26 18:50 ` [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check Mario Limonciello
2017-09-26 20:11 ` Pali Rohár [this message]
2017-09-26 20:19 ` Mario.Limonciello
2017-09-26 20:19 ` Mario.Limonciello
2017-09-26 19:05 ` [PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI Andy Shevchenko
2017-09-26 19:17 ` Mario.Limonciello
2017-09-26 19:17 ` Mario.Limonciello
2017-09-27 17:11 ` Darren Hart
2017-09-27 17:31 ` Mario.Limonciello
2017-09-27 17:31 ` Mario.Limonciello
2017-09-27 17:36 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201709262211.57222@pali \
--to=pali.rohar@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.