Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools

[Jesper Dangaard Brouer <brouer@redhat.com>]

On Wed, 27 Sep 2017 09:03:34 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> On Mon, 25 Sep 2017 02:25:52 +0200
> Daniel Borkmann <daniel@iogearbox.net> wrote:
> 
> > Looks like a couple of updates missed to get carried into tools/include/uapi/,
> > so copy the bpf.h header as usual to pull in latest updates.
> > 
> > Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> > Acked-by: Alexei Starovoitov <ast@kernel.org>
> > Acked-by: John Fastabend <john.fastabend@gmail.com>
> > ---
> >  tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------
> >  1 file changed, 32 insertions(+), 13 deletions(-)
> > 
> > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> > index 461811e..e43491a 100644
> > --- a/tools/include/uapi/linux/bpf.h
> > +++ b/tools/include/uapi/linux/bpf.h
> > @@ -143,12 +143,6 @@ enum bpf_attach_type {
> >  
> >  #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE
> >  
> > -enum bpf_sockmap_flags {
> > -	BPF_SOCKMAP_UNSPEC,
> > -	BPF_SOCKMAP_STRPARSER,
> > -	__MAX_BPF_SOCKMAP_FLAG
> > -};
> > -  
> 
> Why does "bpf_sockmap_flags" gets removed?
> 
> It got added in: commit 69e8cc134bcb ("bpf: sockmap sample program").
> But I cannot find any users of these flags, so I guess it is okay.

Found the explanation in commit 2f857d04601 ("bpf: sockmap, remove
STRPARSER map_flags and add multi-map support").
 https://git.kernel.org/torvalds/c/2f857d04601

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer