Re: [PATCH 1/8] etnaviv: remove iommu fault handler

["Wladimir J. van der Laan" <laanwj@gmail.com>]

On Fri, Sep 15, 2017 at 07:04:32PM +0200, Lucas Stach wrote:
> The handler has never been used, so it's really just dead code.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Reviewed-by: Wladimir J. van der Laan <laanwj@gmail.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index f103e787de94..f3ed07db9b2d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -22,13 +22,6 @@
>  #include "etnaviv_iommu.h"
>  #include "etnaviv_mmu.h"
>  
> -static int etnaviv_fault_handler(struct iommu_domain *iommu, struct device *dev,
> -		unsigned long iova, int flags, void *arg)
> -{
> -	DBG("*** fault: iova=%08lx, flags=%d", iova, flags);
> -	return 0;
> -}
> -
>  int etnaviv_iommu_map(struct etnaviv_iommu *iommu, u32 iova,
>  		struct sg_table *sgt, unsigned len, int prot)
>  {
> @@ -307,8 +300,6 @@ struct etnaviv_iommu *etnaviv_iommu_new(struct etnaviv_gpu *gpu)
>  		    mmu->domain->geometry.aperture_end -
>  		    mmu->domain->geometry.aperture_start + 1);
>  
> -	iommu_set_fault_handler(mmu->domain, etnaviv_fault_handler, gpu->dev);
> -
>  	return mmu;
>  }
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> etnaviv mailing list
> etnaviv@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel