From: Florian Westphal <fw@strlen.de>
To: Artem Savkov <asavkov@redhat.com>
Cc: Florian Westphal <fw@strlen.de>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock
Date: Wed, 27 Sep 2017 14:31:03 +0200 [thread overview]
Message-ID: <20170927123103.GB14971@breakpoint.cc> (raw)
In-Reply-To: <20170927122537.14235-1-asavkov@redhat.com>
Artem Savkov <asavkov@redhat.com> wrote:
> I might be wrong but it doesn't look like xfrm_state_lock is required
> for xfrm_policy_cache_flush and calling it under this lock triggers both
> "sleeping function called from invalid context" and "possible circular
> locking dependency detected" warnings on flush.
>
> Fixes: ec30d78c14a8 xfrm: add xdst pcpu cache
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
You're right, its not needed (and wrong).
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-09-27 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 12:25 [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock Artem Savkov
2017-09-27 12:31 ` Florian Westphal [this message]
2017-09-28 11:12 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927123103.GB14971@breakpoint.cc \
--to=fw@strlen.de \
--cc=asavkov@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.