From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY
Date: Wed, 27 Sep 2017 16:02:10 +0200 [thread overview]
Message-ID: <20170927140210.GE13516@lunn.ch> (raw)
In-Reply-To: <20170927073414.17361-6-clabbe.montjoie@gmail.com>
Hi Corentin
> +Required properties for the mdio-mux node:
> + - compatible = "mdio-mux"
This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.
> +Required properties of the integrated phy node:
> - clocks: a phandle to the reference clock for the EPHY
> - resets: a phandle to the reset control for the EPHY
> +- phy-is-integrated
So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?
I really would like phy-is-integrated to go away.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY
Date: Wed, 27 Sep 2017 16:02:10 +0200 [thread overview]
Message-ID: <20170927140210.GE13516@lunn.ch> (raw)
In-Reply-To: <20170927073414.17361-6-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Corentin
> +Required properties for the mdio-mux node:
> + - compatible = "mdio-mux"
This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.
> +Required properties of the integrated phy node:
> - clocks: a phandle to the reference clock for the EPHY
> - resets: a phandle to the reset control for the EPHY
> +- phy-is-integrated
So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?
I really would like phy-is-integrated to go away.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, f.fainelli@gmail.com,
frowand.list@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY
Date: Wed, 27 Sep 2017 16:02:10 +0200 [thread overview]
Message-ID: <20170927140210.GE13516@lunn.ch> (raw)
In-Reply-To: <20170927073414.17361-6-clabbe.montjoie@gmail.com>
Hi Corentin
> +Required properties for the mdio-mux node:
> + - compatible = "mdio-mux"
This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.
> +Required properties of the integrated phy node:
> - clocks: a phandle to the reference clock for the EPHY
> - resets: a phandle to the reset control for the EPHY
> +- phy-is-integrated
So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?
I really would like phy-is-integrated to go away.
Andrew
next prev parent reply other threads:[~2017-09-27 14:02 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 7:34 [PATCH v6 00/11] net: stmmac: dwmac-sun8i: Handle integrated PHY Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 01/11] dt-bindings: net: Restore sun8i dwmac binding Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-10-05 20:59 ` Rob Herring
2017-10-05 20:59 ` Rob Herring
2017-10-05 20:59 ` Rob Herring
2017-09-27 7:34 ` [PATCH v6 02/11] arm: dts: sunxi: Restore EMAC changes Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 03/11] arm64: dts: allwinner: " Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 04/11] net: stmmac: sun8i: Restore the compatibles Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 10:15 ` Maxime Ripard
2017-09-27 10:15 ` Maxime Ripard
2017-09-27 10:15 ` Maxime Ripard
2017-09-27 14:02 ` Andrew Lunn [this message]
2017-09-27 14:02 ` Andrew Lunn
2017-09-27 14:02 ` Andrew Lunn
2017-09-28 7:37 ` Corentin Labbe
2017-09-28 7:37 ` Corentin Labbe
2017-09-28 7:37 ` Corentin Labbe
2017-10-04 19:00 ` Corentin Labbe
2017-10-04 19:00 ` Corentin Labbe
2017-10-04 19:00 ` Corentin Labbe
2017-10-08 18:33 ` Corentin Labbe
2017-10-08 18:33 ` Corentin Labbe
2017-10-09 21:08 ` Maxime Ripard
2017-10-09 21:08 ` Maxime Ripard
2017-10-09 21:08 ` Maxime Ripard
2017-09-28 4:53 ` Florian Fainelli
2017-09-28 4:53 ` Florian Fainelli
2017-09-28 4:53 ` Florian Fainelli
2017-09-28 7:07 ` Corentin Labbe
2017-09-28 7:07 ` Corentin Labbe
2017-09-28 7:07 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 06/11] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 10:16 ` Maxime Ripard
2017-09-27 10:16 ` Maxime Ripard
2017-09-27 10:16 ` Maxime Ripard
2017-09-27 13:47 ` Corentin Labbe
2017-09-27 13:47 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 07/11] arm64: dts: allwinner: add snps, dwmac-mdio compatible to emac/mdio Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 07/11] arm64: dts: allwinner: add snps,dwmac-mdio " Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 08/11] net: stmmac: snps, dwmac-mdio MDIOs are automatically registered Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 08/11] net: stmmac: snps,dwmac-mdio " Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 09/11] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 10/11] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 7:34 ` Corentin Labbe
2017-09-27 14:12 ` Andrew Lunn
2017-09-27 14:12 ` Andrew Lunn
2017-09-27 14:12 ` Andrew Lunn
2017-09-28 4:50 ` Florian Fainelli
2017-09-28 4:50 ` Florian Fainelli
2017-09-28 4:50 ` Florian Fainelli
2017-10-05 22:09 ` Rob Herring
2017-10-05 22:09 ` Rob Herring
2017-10-05 22:09 ` Rob Herring
2017-10-05 22:21 ` Andrew Lunn
2017-10-05 22:21 ` Andrew Lunn
2017-10-05 22:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927140210.GE13516@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.