Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Wed, Sep 27, 2017 at 04:18:50PM +0000, Kalderon, Michal wrote:
> From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Sent: Wednesday, September 27, 2017 4:27 PM
>
> >On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote:
> >> Initialize the rdma_type (iWARP or RoCE) which is set according to
> >> device configuration in qed.
> >>
> >> Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an iWARP
> >> device")
> >>
> >> Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >> Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >>
> >> ---
> >> This patch applies cleanly on k.o/for-next-merged
> >>
> >> Changes from V0:
> >> - Added Fixes in commit comment.
> >
> >Sorry, I was wrong in my email to the previous posting of this patch.
> >I had pulled this v1 patch from patchworks, not the original patch, and
> >so the Fixes: line was yours.  Patchworks did not add the Fixes: line
> >to the v0 patch when I downloaded it just now.
>
> >That being said, I still can't build with this patch ;-)
> Are you building against the rdma-next branch ?
> The patch requires the iWARP series, originally this was tested against for-next-merged,
> what's the error you're getting ?

On rdma-next:
drivers/infiniband/hw/qedr/main.c: In function ‘qedr_add’:
drivers/infiniband/hw/qedr/main.c:780:7: error: ‘struct qedr_dev’ has no member named ‘rdma_type’; did you mean ‘rdma_ctx’?
  dev->rdma_type = dev_info.rdma_type;
       ^~~~~~~~~
       rdma_ctx
make[4]: *** [scripts/Makefile.build:311: drivers/infiniband/hw/qedr/main.o] Error 1


>
> thanks,
> Michal
>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG KeyID: B826A3330E572FDD
>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]