Re: [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

On Wed, Sep 27, 2017 at 02:23:43PM -0300, Otavio Salvador wrote:
> Hello Andrei,
> 
> On Wed, Sep 27, 2017 at 2:13 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > On Wed, Sep 27, 2017 at 4:23 PM, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> >>
> >> * this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
> >> * this makes qtbase and everything which depends on some qt* recipe to
> >>   be effectivelly MACHINE_ARCH
> >>
> >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> ---
> >>  dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 ---
> >>  1 file changed, 3 deletions(-)
> >>  delete mode 100644
> >> dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >>
> >> diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> deleted file mode 100644
> >> index ae3f1d3..0000000
> >> --- a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
> >> +++ /dev/null
> >> @@ -1,3 +0,0 @@
> >> -# Copyright (C) 2017 O.S. Systems Software LTDA.
> >> -
> >> -PACKAGECONFIG_GL_rpi   = "gles2 eglfs"
> >
> >
> > What would be the solution though?
> 
> It would use something similar we use for meta-freescale where we
> change the package architecture depending on the SoC.
> 
> Martin, do you have any idea how other alternative we have?

In theory you can set QT_PACKAGES_ARCH to MACHINE_ARCH in rpi-base.inc
to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3
will each build it's own qtwebengine and all it's deps even when it
should be the same for both).

I think the only usable solution is to let DISTRO to decide the policy,
as Khem suggested DISTRO_FEATURES is first step, if it isn't enough (in
this case it's difficult to distinguish e.g. opengl and gles2 when there
is opengl in DISTRO_FEATURES). So I would leave it to DISTRO maintainers
to decide if they can enable "gles2 eglfs" globally for all MACHINEs in
distro bbappend, or they can enable it only for some DEFAULT_TUNE (or
e.g. for all arm MACHINEs and leave desktop gl for x86).

But forcing this policy from BSP is bad.

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]