From: Manasi Navare <manasi.d.navare@intel.com>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/dp: Do not prune the last mode on the connector
Date: Wed, 27 Sep 2017 17:48:58 -0700 [thread overview]
Message-ID: <20170928004858.GA3302@intel.com> (raw)
In-Reply-To: <87a81fslxf.fsf@keithp.com>
On Wed, Sep 27, 2017 at 05:31:56PM -0700, Keith Packard wrote:
> Manasi Navare <manasi.d.navare@intel.com> writes:
>
> > This patch fixes this problem by checking if the mode being pruned
> > is the last mode on that connector and if so doesnt prune it.
>
> I think you want to stop pruning when you've gotten to a single mode on
> the list, not at the last mode in the list (which may well need to be
> pruned).
>
> This is entirely untested, but perhaps
>
> + !(list_is_singular(mode_list))) {
>
> is what you want?
>
Thanks Keith. Yes thats correct, I got confused by the macro name.
But its correct I should use the list_is_singular instead.
Manasi
> --
> -keith
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-28 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 0:00 [PATCH] drm/dp: Do not prune the last mode on the connector Manasi Navare
2017-09-28 0:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-09-28 0:31 ` [PATCH] " Keith Packard
2017-09-28 0:48 ` Manasi Navare [this message]
2017-09-28 1:04 ` [PATCH v2] " Manasi Navare
2017-09-28 1:22 ` ✗ Fi.CI.BAT: failure for drm/dp: Do not prune the last mode on the connector (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928004858.GA3302@intel.com \
--to=manasi.d.navare@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.