From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dxLXf-0002NV-To for mharc-qemu-trivial@gnu.org; Wed, 27 Sep 2017 19:14:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxLXe-0002Ml-EF for qemu-trivial@nongnu.org; Wed, 27 Sep 2017 19:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxLXd-0008PP-JC for qemu-trivial@nongnu.org; Wed, 27 Sep 2017 19:14:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36408) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dxLXX-0008L9-BZ; Wed, 27 Sep 2017 19:14:51 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 082F12DBE66; Wed, 27 Sep 2017 23:14:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 082F12DBE66 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mst@redhat.com Received: from redhat.com (ovpn-123-149.rdu2.redhat.com [10.10.123.149]) by smtp.corp.redhat.com (Postfix) with SMTP id 594A27E58F; Wed, 27 Sep 2017 23:14:46 +0000 (UTC) Date: Thu, 28 Sep 2017 02:14:45 +0300 From: "Michael S. Tsirkin" To: Peter Maydell Cc: Michael Tokarev , Thomas Huth , Victor Kaplansky , QEMU Trivial , Stefan Weil , Jason Wang , QEMU Developers Message-ID: <20170928020110-mutt-send-email-mst@kernel.org> References: <1506049617-25716-1-git-send-email-thuth@redhat.com> <513bbb2d-280b-92f8-b45f-89963f7118e2@msgid.tls.msk.ru> <20170926223046-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 27 Sep 2017 23:14:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 23:14:59 -0000 On Tue, Sep 26, 2017 at 08:35:59PM +0100, Peter Maydell wrote: > On 26 September 2017 at 20:31, Michael S. Tsirkin wrote: > > On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: > >> 22.09.2017 06:06, Thomas Huth wrote: > >> > If QEMU has been compiled with the flags --enable-tcg-interpreter and > >> > --enable-debug, the guest is running incredibly slow. The pxe boot test > >> > can take up to 400 seconds when testing the pseries ppc64 machine. While > >> > we should still look for ways to speed up the test on the pseries machine, > >> > it's better to increase the timeout in this test to 600 seconds anyway to > >> > allow the test to pass successfully now with this unusal configuration > >> > already. > >> > >> Applied to -trivial, thanks! > >> > >> /mjt > > > > Please do not apply this, trivial is not appropriate for functional > > changes like this. > > It's not a functional change, it's just bumping a test timeout. > If you think we should be doing something else that's fine (as > with any other patch), but in principle I think this is totally > fine as a -trivial patch. > > thanks > -- PMM OK. I'd rather not see it applied as-is though. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxLXc-0002Mf-Jm for qemu-devel@nongnu.org; Wed, 27 Sep 2017 19:14:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxLXX-0008Lb-IA for qemu-devel@nongnu.org; Wed, 27 Sep 2017 19:14:56 -0400 Date: Thu, 28 Sep 2017 02:14:45 +0300 From: "Michael S. Tsirkin" Message-ID: <20170928020110-mutt-send-email-mst@kernel.org> References: <1506049617-25716-1-git-send-email-thuth@redhat.com> <513bbb2d-280b-92f8-b45f-89963f7118e2@msgid.tls.msk.ru> <20170926223046-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Michael Tokarev , Thomas Huth , Victor Kaplansky , QEMU Trivial , Stefan Weil , Jason Wang , QEMU Developers On Tue, Sep 26, 2017 at 08:35:59PM +0100, Peter Maydell wrote: > On 26 September 2017 at 20:31, Michael S. Tsirkin wrote: > > On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: > >> 22.09.2017 06:06, Thomas Huth wrote: > >> > If QEMU has been compiled with the flags --enable-tcg-interpreter and > >> > --enable-debug, the guest is running incredibly slow. The pxe boot test > >> > can take up to 400 seconds when testing the pseries ppc64 machine. While > >> > we should still look for ways to speed up the test on the pseries machine, > >> > it's better to increase the timeout in this test to 600 seconds anyway to > >> > allow the test to pass successfully now with this unusal configuration > >> > already. > >> > >> Applied to -trivial, thanks! > >> > >> /mjt > > > > Please do not apply this, trivial is not appropriate for functional > > changes like this. > > It's not a functional change, it's just bumping a test timeout. > If you think we should be doing something else that's fine (as > with any other patch), but in principle I think this is totally > fine as a -trivial patch. > > thanks > -- PMM OK. I'd rather not see it applied as-is though. -- MST