From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.luessing@c0d3.blue (Linus =?utf-8?Q?L=C3=BCssing?=) Date: Thu, 28 Sep 2017 04:23:46 +0200 Subject: [PATCH 2/4] ARM: dts: meson8b: extending ethernet controller description In-Reply-To: References: Message-ID: <20170928022346.GB6726@otheros> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Wed, Sep 27, 2017 at 11:39:53PM +0200, Emiliano Ingrassia wrote: > This patch corrects the meson8b-dwmac reg attributes updated by the previous > 2/4 patch (450a483abe07f8d903c6cb74091592743975a8eb). > The second addresses range, taken from S805 (aka Meson8b) SoC manual, > was not correct. > > [..] > ðmac { > - clocks = <&clkc CLKID_ETH>; > - clock-names = "stmmaceth"; > + compatible = "amlogic,meson8b-dwmac", "snps,dwmac-3.70a", "snps,dwmac"; > + > + interrupts = , > + ; > + interrupt-names = "macirq", > + "eth_lpi"; > + > + clock-names = "stmmaceth", "clkin0", "clkin1"; > + clocks = <&clkc CLKID_ETH>, > + <&clkc CLKID_FCLK_DIV2>, > + <&clkc CLKID_MPLL2>; > + > + resets = <&reset RESET_ETHERNET>; > + reset-names = "stmmaceth"; > + > + rx-fifo-depth=<4000>; > + tx-fifo-depth=<2000>; > }; Hi Emiliano, Did you accidentally delete instead of replace the reg values? (or are there default values hidden somewhere else?) Also, please don't forget to add a v2/v3/etc. next time, makes it easier to follow here and in Patchwork, thanks :-). And thanks a lot at looking into ethernet support as well. Will try this patchset soon, too! You guys are killing it :D! Regards, Linus