From: Vinod Koul <vinod.koul@intel.com>
To: Chintan Patel <chintan.m.patel@intel.com>
Cc: alsa-devel@alsa-project.org, Hsin-yu Chao <hychao@google.com>,
harshapriya.n@intel.com, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Mark Brown <broonie@kernel.org>, Jeeja KP <jeeja.kp@intel.com>,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>,
naveen.m@intel.com
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
Date: Thu, 28 Sep 2017 08:40:36 +0530 [thread overview]
Message-ID: <20170928031036.GU30097@localhost> (raw)
In-Reply-To: <1505749403-31346-1-git-send-email-chintan.m.patel@intel.com>
On Mon, Sep 18, 2017 at 08:43:18AM -0700, Chintan Patel wrote:
> Jack name is not getting formatted correctly hence resulting
> in invalid name for HDMI/DP input devices.
>
> This was recently exposed due changes brought by MST:
> commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
> in kbl machine drivers")
Acked-By: Vinod Koul <vinod.koul@intel.com>
>
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index 4689991bcc86..c127b7b0ee3f 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
>
> list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
> codec = pcm->codec_dai->codec;
> + snprintf(jack_name, sizeof(jack_name),
> + "HDMI/DP, pcm=%d Jack", pcm->device);
> err = snd_soc_card_jack_new(card, jack_name,
> SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
> NULL, 0);
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
~Vinod
next prev parent reply other threads:[~2017-09-28 3:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 15:43 [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution Chintan Patel
2017-09-18 15:43 ` Chintan Patel
2017-09-28 3:10 ` Vinod Koul [this message]
2017-09-28 18:58 ` Applied "ASoC: Intel: Skylake: Fix jack name format substitution" to the asoc tree Mark Brown
2017-09-28 18:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928031036.GU30097@localhost \
--to=vinod.koul@intel.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chintan.m.patel@intel.com \
--cc=harshapriya.n@intel.com \
--cc=hychao@google.com \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.