From: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH] amdgpu/dc: remove wait_reg/wait_reg_func interfaces.
Date: Thu, 28 Sep 2017 13:29:32 +1000 [thread overview]
Message-ID: <20170928032932.9324-1-airlied@gmail.com> (raw)
From: Dave Airlie <airlied@redhat.com>
These aren't used in the tree anywhere, and there is a TODO.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dm_services.h | 46 ----------------------------
1 file changed, 46 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h b/drivers/gpu/drm/amd/display/dc/dm_services.h
index c976e2a..8166027 100644
--- a/drivers/gpu/drm/amd/display/dc/dm_services.h
+++ b/drivers/gpu/drm/amd/display/dc/dm_services.h
@@ -236,52 +236,6 @@ unsigned int generic_reg_wait(const struct dc_context *ctx,
block ## reg_num ## _ ## reg_name ## __ ## reg_field ## _MASK,\
block ## reg_num ## _ ## reg_name ## __ ## reg_field ## __SHIFT)
-/* TODO get rid of this pos*/
-static inline bool wait_reg_func(
- const struct dc_context *ctx,
- uint32_t addr,
- uint32_t mask,
- uint8_t shift,
- uint32_t condition_value,
- unsigned int interval_us,
- unsigned int timeout_us)
-{
- uint32_t field_value;
- uint32_t reg_val;
- unsigned int count = 0;
-
- if (IS_FPGA_MAXIMUS_DC(ctx->dce_environment))
- timeout_us *= 655; /* 6553 give about 30 second before time out */
-
- do {
- /* try once without sleeping */
- if (count > 0) {
- if (interval_us >= 1000)
- msleep(interval_us/1000);
- else
- udelay(interval_us);
- }
- reg_val = dm_read_reg(ctx, addr);
- field_value = get_reg_field_value_ex(reg_val, mask, shift);
- count += interval_us;
-
- } while (field_value != condition_value && count <= timeout_us);
-
- ASSERT(count <= timeout_us);
-
- return count <= timeout_us;
-}
-
-#define wait_reg(ctx, inst_offset, reg_name, reg_field, condition_value)\
- wait_reg_func(\
- ctx,\
- mm##reg_name + inst_offset + DCE_BASE.instance[0].segment[mm##reg_name##_BASE_IDX],\
- reg_name ## __ ## reg_field ## _MASK,\
- reg_name ## __ ## reg_field ## __SHIFT,\
- condition_value,\
- 20000,\
- 200000)
-
/**************************************
* Power Play (PP) interfaces
**************************************/
--
2.9.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2017-09-28 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 3:29 Dave Airlie [this message]
[not found] ` <20170928032932.9324-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-28 14:20 ` [PATCH] amdgpu/dc: remove wait_reg/wait_reg_func interfaces Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928032932.9324-1-airlied@gmail.com \
--to=airlied-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.