All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kamlakant Patel <kamlakant.patel@cavium.com>
Cc: linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
	Wolfram Sang <wsa@the-dreams.de>,
	Jayachandran C <jnair@caviumnetworks.com>
Subject: Re: [PATCH 3/3] i2c: xlp9xx: Handle I2C_M_RECV_LEN in msg->flags
Date: Thu, 28 Sep 2017 11:50:21 +0300	[thread overview]
Message-ID: <20170928085021.GM4630@lahna.fi.intel.com> (raw)
In-Reply-To: <1506523943-8632-4-git-send-email-kamlakant.patel@cavium.com>

On Wed, Sep 27, 2017 at 08:22:23PM +0530, Kamlakant Patel wrote:
> +	priv->len_recv = (msg->flags & I2C_M_RECV_LEN);

You don't need parens here.

> +	len = priv->len_recv ? XLP9XX_I2C_FIFO_SIZE : msg->len;
> +	priv->client_pec = (msg->flags & I2C_CLIENT_PEC);

Ditto.

Otherwise looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

      reply	other threads:[~2017-09-28  8:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 14:52 [PATCH 0/3] i2c-xlp9xx: update i2c driver to handle I2C_M_RECV_LEN flag Kamlakant Patel
2017-09-27 14:52 ` [PATCH 1/3] ACPI / APD: Add clock frequency for ThunderX2 I2C controller Kamlakant Patel
2017-09-28  8:45   ` Mika Westerberg
2017-09-27 14:52 ` [PATCH 2/3] i2c: xlp9xx: Get clock frequency with clk API Kamlakant Patel
2017-09-28  8:49   ` Mika Westerberg
2017-09-27 14:52 ` [PATCH 3/3] i2c: xlp9xx: Handle I2C_M_RECV_LEN in msg->flags Kamlakant Patel
2017-09-28  8:50   ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170928085021.GM4630@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=jnair@caviumnetworks.com \
    --cc=kamlakant.patel@cavium.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.