From: Eduardo Habkost <ehabkost@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups
Date: Thu, 28 Sep 2017 17:54:24 -0300 [thread overview]
Message-ID: <20170928205424.GV4115@localhost.localdomain> (raw)
In-Reply-To: <3e0e7e4a-0e66-ef49-8ee7-02e6ffd424b4@redhat.com>
On Wed, Sep 27, 2017 at 03:49:55PM -0500, Eric Blake wrote:
> On 09/27/2017 03:41 PM, Eduardo Habkost wrote:
> > Change qemu_config_parse() to return the number of config groups
> > in success and -EINVAL on error. This will allow callers of
> > qemu_config_parse() to check if something was really loaded from
> > the config file.
> >
> > All existing callers of qemu_config_parse() and
> > qemu_read_config_file() only check if the return value was
> > negative, so the change shouldn't affect them.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> > Changes v2 -> v3:
> > * None (rebase only)
> >
> > Changes v1 -> v2:
> > * Remove unnecessary translation of qemu_config_parse()
> > erros to -EINVAL at block/blkdebug.c:read_config()
> > * Suggsted-by: Markus Armbruster <armbru@redhat.com>
>
> Do you want the Suggested-by (spelled correctly) in the commit body proper?
This line refers to a one-line change in the patch between v1 and
v2, only. Doesn't seem appropriate for a Suggested-by line in
the commit message.
--
Eduardo
next prev parent reply other threads:[~2017-09-28 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 20:41 [Qemu-devel] [PATCH v3 0/2] vl: Print warning if a non-empty default config file is found Eduardo Habkost
2017-09-27 20:41 ` [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups Eduardo Habkost
2017-09-27 20:49 ` Eric Blake
2017-09-28 20:54 ` Eduardo Habkost [this message]
2017-10-02 8:51 ` Markus Armbruster
2017-09-27 20:41 ` [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config file is loaded Eduardo Habkost
2017-09-27 20:47 ` Eric Blake
2017-09-28 20:52 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928205424.GV4115@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.