From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] support/testing: fix remaining code style
Date: Fri, 29 Sep 2017 10:29:33 +0200 [thread overview]
Message-ID: <20170929082933.GG2899@scaer> (raw)
In-Reply-To: <20170929080419.GA2899@scaer>
On 2017-09-29 10:04 +0200, Yann E. MORIN spake thusly:
> On 2017-09-28 23:27 -0300, Ricardo Martincoski spake thusly:
[--SNIP--]
> > diff --git a/support/testing/infra/basetest.py b/support/testing/infra/basetest.py
> > index 9d5f714b02..045f5e80a4 100644
> > --- a/support/testing/infra/basetest.py
> > +++ b/support/testing/infra/basetest.py
> > @@ -41,13 +41,14 @@ class BRTest(unittest.TestCase):
> > def __init__(self, names):
> > super(BRTest, self).__init__(names)
> > self.testname = self.__class__.__name__
> > - self.builddir = self.outputdir and os.path.join(self.outputdir, self.testname)
> > + self.builddir = self.outputdir and os.path.join(self.outputdir,
> > + self.testname)
>
> I think that in such situation, a better break would be right after the
> 'and' operator [...]
PEP8 states to split before binary operators.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-09-29 8:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 2:27 [Buildroot] [PATCH 1/5] support/testing: standardize defconfig fragments style Ricardo Martincoski
2017-09-29 2:27 ` [Buildroot] [PATCH 2/5] support/testing: indent ccache defconfig fragment Ricardo Martincoski
2017-09-29 8:17 ` Yann E. MORIN
2017-10-02 1:03 ` Ricardo Martincoski
2017-10-02 5:49 ` Yann E. MORIN
2017-10-02 23:03 ` Ricardo Martincoski
2017-09-29 2:27 ` [Buildroot] [PATCH 3/5] support/testing: fix code style Ricardo Martincoski
2017-09-29 8:21 ` Yann E. MORIN
2017-09-29 2:27 ` [Buildroot] [PATCH 4/5] support/testing: fix remaining " Ricardo Martincoski
2017-09-29 8:04 ` Yann E. MORIN
2017-09-29 8:29 ` Yann E. MORIN [this message]
2017-10-02 1:09 ` Ricardo Martincoski
2017-10-02 6:06 ` Yann E. MORIN
2017-10-02 13:48 ` Arnout Vandecappelle
2017-10-02 14:20 ` Peter Korsgaard
2017-09-29 2:27 ` [Buildroot] [PATCH 5/5] testing/tests/init: use lowercase method names Ricardo Martincoski
2017-09-29 8:23 ` Yann E. MORIN
2017-09-29 8:13 ` [Buildroot] [PATCH 1/5] support/testing: standardize defconfig fragments style Yann E. MORIN
2017-09-29 8:15 ` Yann E. MORIN
2017-10-05 21:42 ` [Buildroot] [PATCH v2 1/6] support/testing: allow to indent ccache defconfig fragment Ricardo Martincoski
2017-10-05 21:42 ` [Buildroot] [PATCH v2 2/6] support/testing: standardize defconfig fragments style Ricardo Martincoski
2017-10-05 21:42 ` [Buildroot] [PATCH v2 3/6] support/testing: fix code style Ricardo Martincoski
2017-10-05 21:42 ` [Buildroot] [PATCH v2 4/6] testing/tests/init: use lowercase method names Ricardo Martincoski
2017-10-06 17:09 ` Arnout Vandecappelle
2017-10-05 21:42 ` [Buildroot] [PATCH v2 5/6] .flake8: add config file for Python code style Ricardo Martincoski
2017-10-06 17:10 ` Arnout Vandecappelle
2017-10-05 21:42 ` [Buildroot] [PATCH v2 6/6] support/testing: fix remaining " Ricardo Martincoski
2017-10-06 17:16 ` Arnout Vandecappelle
2017-10-23 2:30 ` Ricardo Martincoski
2017-10-23 8:34 ` Arnout Vandecappelle
2017-10-29 4:03 ` Ricardo Martincoski
2017-10-29 20:20 ` Arnout Vandecappelle
2017-10-06 17:07 ` [Buildroot] [PATCH v2 1/6] support/testing: allow to indent ccache defconfig fragment Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929082933.GG2899@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.