Re: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Sep 28, 2017 at 08:20:09PM -0400, Programmingkid wrote:
> 
> > On Sep 28, 2017, at 12:53 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
> > 
> > On Thu, Sep 28, 2017 at 12:47:51PM -0400, Programmingkid wrote:
> >> 
> >>> This patch series is an update to:
> >>> 
> >>> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html
> >>> v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html
> >>> v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html
> >>> v4: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02708.html
> >>> v5: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02950.html
> >>> v6: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg07673.html
> >> 
> >> <snip>
> >> 
> >> These error messages appears when compiling version 7 of this patch series:
> >> 
> >> /bin/sh: ./scripts/git-submodule.sh: Permission denied
> > 
> > The git diff sets execute permission:
> > 
> > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
> > new file mode 100755
> > index 0000000000..f8e7d44ce6
> > --- /dev/null
> > +++ b/scripts/git-submodule.sh
> > 
> > did you use "git am" to apply this series or just plain 'patch', because
> > the latter won't deal with permissions correctly and so would cause that
> > error message above.
> 
> I used the patch command. After trying again using 'git am' I was able to built QEMU. Even thought the build did succeed, this error message still appeared: 
> 
> config-host.mak is out-of-date, running configure
>   GIT     ui/keycodemapdb dtc
> make: *** No rule to make target `ui/input-keymap-linux-to-qcode.c', needed by `Makefile'.  Stop.
> make: *** Waiting for unfinished jobs....
> 
> I suggest adding a note to patch 0/7 that states this patch set is best
> applied using 'git am' instead of the patch command. That should help
> someone with testing out this patch set.

*All* patches sent to qemu-devel for review should be applied with
'git am', so there's no need to call it out specially.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|