From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [Outreachy kernel] [PATCH v2 02/10] Staging: media: atomisp: Remove useless 'out of memory' messages
Date: Fri, 29 Sep 2017 15:34:17 +0200 [thread overview]
Message-ID: <20170929133417.GA4057@kroah.com> (raw)
In-Reply-To: <6994f57188755df17d3ef47a36a4f4ec032dcb4d.1506436974.git.georgiana.chelu93@gmail.com>
On Tue, Sep 26, 2017 at 09:01:30AM -0700, Georgiana Chelu wrote:
> OOM (Out Of Memory Manager) reports memory allocation fails,
> so there is no need for the error messages.
>
> Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
> ---
>
> Changes in v2:
> * this is a new patch added to the patchset
>
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> index 5232327..8667466 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> @@ -728,7 +728,6 @@ static int alloc_private_pages(struct hmm_buffer_object *bo,
> bo->page_obj = kmalloc_array(pgnr, sizeof(struct hmm_page_object),
> GFP_KERNEL);
> if (unlikely(!bo->page_obj)) {
> - dev_err(atomisp_dev, "out of memory for bo->page_obj\n");
> return -ENOMEM;
> }
The { } should also be removed when you do this. Please fix that up
here.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-29 13:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 16:01 [PATCH v2 00/10] Fix checkpatch issues Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 01/10] Staging: media: atomisp: Use kmalloc_array instead of kmalloc Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 02/10] Staging: media: atomisp: Remove useless 'out of memory' messages Georgiana Chelu
2017-09-29 13:34 ` Greg Kroah-Hartman [this message]
2017-10-01 11:37 ` [Outreachy kernel] " Georgiana Chelu
2017-10-01 11:47 ` Julia Lawall
2017-10-01 11:56 ` Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 03/10] Staging: media: atomisp: Remove unlikely from NULL pointer check Georgiana Chelu
2017-09-29 13:35 ` Greg Kroah-Hartman
2017-09-26 16:01 ` [PATCH v2 04/10] Staging: media: atomisp: Adjust checks for null pointers Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 05/10] Staging: media: atomisp: Remove return statement from void function Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 06/10] Staging: media: atomisp: Add spaces around bitwise OR Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 07/10] Staging: media: atomisp: Remove braces {} for single statement blocks Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 08/10] Staging: media: atomisp: Align code with open parenthesis Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 09/10] Staging: media: atomisp: Merge quoted string split across lines Georgiana Chelu
2017-09-26 16:01 ` [PATCH v2 10/10] Staging: media: atomisp: Split lines wiht over 80 characters Georgiana Chelu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929133417.GA4057@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgiana.chelu93@gmail.com \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.