Re: [PATCH] Staging: media: atomisp: Remove duplicated argument to ||

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Sep 22, 2017 at 04:20:55AM -0700, Georgiana Chelu wrote:
> get_user() copies a variable from user space to kernel space
> put_user() copies a variable from kenel space to user space.
> 
> Remove duplicated argument to || because consecutive calls
> of these functions with the same arguments will have the same
> result.
> 
> Issue found by coccinelle script.
> 
> Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c
> index 0592ac1..a27ecbe 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c
> @@ -432,8 +432,6 @@ static int get_atomisp_overlay32(struct atomisp_overlay *kp,
>  				&up->blend_overlay_perc_u) ||
>  		get_user(kp->blend_overlay_perc_v,
>  				&up->blend_overlay_perc_v) ||
> -		get_user(kp->blend_overlay_perc_u,
> -				&up->blend_overlay_perc_u) ||
>  		get_user(kp->overlay_start_x, &up->overlay_start_y))
>  			return -EFAULT;
>  

I don't understand, you are changing the output of the code here, right?
Why is this patch ok?

confused,

greg k-h