diff for duplicates of <20170929225949.GP8463@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index bed9695..d59d7a4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote: +On Thu, Sep 28, 2017@09:36:36PM +0200, Martin Wilck wrote: > In the NVME subsystem, we're seeing a race condition with udev where > device_add_disk() is called (which triggers an "add" uevent), and a > sysfs attribute group is added to the disk device afterwards. @@ -10,11 +10,11 @@ On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote: > device_add_disk_with_groups(), which takes a list of attribute groups > and adds them to the device before sending out uevents. > -> Signed-off-by: Martin Wilck <mwilck@suse.com> +> Signed-off-by: Martin Wilck <mwilck at suse.com> Is NVMe the only one having this problem? Was putting our attributes in the disk's kobj a bad choice? Any, looks fine to me. -Reviewed-by: Keith Busch <keith.busch@intel.com> +Reviewed-by: Keith Busch <keith.busch at intel.com> diff --git a/a/content_digest b/N1/content_digest index b9c253f..6caa178 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,10 @@ "ref\020170928193637.24707-1-mwilck@suse.com\0" - "From\0Keith Busch <keith.busch@intel.com>\0" - "Subject\0Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups\0" + "From\0keith.busch@intel.com (Keith Busch)\0" + "Subject\0[PATCH 1/2] block: genhd: add device_add_disk_with_groups\0" "Date\0Fri, 29 Sep 2017 16:59:49 -0600\0" - "To\0Martin Wilck <mwilck@suse.com>\0" - "Cc\0Jens Axboe <axboe@kernel.dk>" - Christoph Hellwig <hch@lst.de> - Johannes Thumshirn <jthumshirn@suse.de> - linux-block@vger.kernel.org - linux-kernel@vger.kernel.org - Hannes Reinecke <hare@suse.de> - linux-nvme@lists.infradead.org - " Martin Wilck <mwilck@suse.de>\0" "\00:1\0" "b\0" - "On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote:\n" + "On Thu, Sep 28, 2017@09:36:36PM +0200, Martin Wilck wrote:\n" "> In the NVME subsystem, we're seeing a race condition with udev where\n" "> device_add_disk() is called (which triggers an \"add\" uevent), and a\n" "> sysfs attribute group is added to the disk device afterwards.\n" @@ -25,13 +16,13 @@ "> device_add_disk_with_groups(), which takes a list of attribute groups\n" "> and adds them to the device before sending out uevents.\n" "> \n" - "> Signed-off-by: Martin Wilck <mwilck@suse.com>\n" + "> Signed-off-by: Martin Wilck <mwilck at suse.com>\n" "\n" "Is NVMe the only one having this problem? Was putting our attributes in\n" "the disk's kobj a bad choice?\n" "\n" "Any, looks fine to me.\n" "\n" - Reviewed-by: Keith Busch <keith.busch@intel.com> + Reviewed-by: Keith Busch <keith.busch at intel.com> -1a66cad1f082074bc3ff8f619b212aee8201cdb22ef2705eb87247088ef8a5a1 +5df3b59ce25f2d848825e9305c9bc8a9d160e9f623fa8797625ec3f8df56b9a8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.