All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2] VFS: Handle lazytime in do_mount()
Date: Sat, 30 Sep 2017 09:10:22 +0200	[thread overview]
Message-ID: <20170930071022.GA238@x4> (raw)
In-Reply-To: <20170919152500.ce62nirm7gu3lqvq@rh_laptop>

On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote:
> On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:
> > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> > internal superblock flags") the lazytime mount option didn't get passed
> > on anymore.
> > 
> > Fix the issue by handling the option in do_mount().
> > 
> > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> > ---
> >  fs/namespace.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index 54059b142d6b..b633838b8f02 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
> >  			    SB_MANDLOCK |
> >  			    SB_DIRSYNC |
> >  			    SB_SILENT |
> > -			    SB_POSIXACL);
> > +			    SB_POSIXACL |
> > +			    SB_LAZYTIME);
> 
> Looks good. Although I still think that this can be per mountpoint options.
> 
> Regardless of that, you can add
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Ping?
Al could you please take look? 
Thanks.

-- 
Markus

  reply	other threads:[~2017-09-30  7:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 19:26 mounting with lazytime doesn't work on ext4 Markus Trippelsdorf
2017-09-19  8:35 ` Markus Trippelsdorf
2017-09-19 10:18   ` [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf
2017-09-19 10:37     ` [PATCH v2] " Markus Trippelsdorf
2017-09-19 15:25       ` Lukas Czerner
2017-09-30  7:10         ` Markus Trippelsdorf [this message]
2017-09-19 14:46   ` mounting with lazytime doesn't work on ext4 Lukas Czerner
2017-09-19 14:55     ` Markus Trippelsdorf
2017-09-19 11:00 ` Lukas Czerner
2017-09-19 11:03   ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930071022.GA238@x4 \
    --to=markus@trippelsdorf.de \
    --cc=adilger.kernel@dilger.ca \
    --cc=dhowells@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.